From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0FCA26F153; Fri, 2 Sep 2022 15:09:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0FCA26F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1662120568; bh=ModXNFvkrbeuYEpmD7FWH02XLJgdJu+9ip6RJW3sp6s=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WjNhiN3qN+vnK4S/7kq5izLOm7k2rvj9LxN0oQ5zfpx2/9wbWjD20eVa81L/x7h/S Q0lqbAukO+7dXHtKYMcdHKWU+K6BD0KvM79UXyv/5EALT7Nw5FrRf7fD/f81A3mjmd r5X5frb+DmOFv34yne5CHh4sksYhXPbTfZAKqbMc= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 657966F153 for ; Fri, 2 Sep 2022 15:09:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 657966F153 Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1oU5UB-00081W-Oe; Fri, 02 Sep 2022 15:09:24 +0300 Message-ID: Date: Fri, 2 Sep 2022 15:09:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Igor Munkin References: <9d4258549598fa5c11a4da1a40ca50cbb6281a16.1660216002.git.imun@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9029AF47137F508F1C97F22BCEC3CC574C87E4AEE44C3974900894C459B0CD1B9ED958AFD3E850165D585FF89AEC24BBAF784538C603896700B100F9AFB84C8EA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE705C173BDDADFC82AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B05885A782BE20C5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BA56B73C5E554AFFC223B1601A0CEE8A58CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C643FE6A0CAC512C79735652A29929C6C4AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C32D7E768E06EC9FDBBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE732FCE54C4D9A645443847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B08A4617502E5AEC047CE36540D89DA4341ECB6F6B7CC2E998C5C58F717A8819149C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3463DBE2ADA183F62FFDF2E13AD1A315D14C20CB5C20430D48ECB5008F2979BD8C12ADCD53EC1A1B5A1D7E09C32AA3244C390054AE68B1B317491734CFD803B092A995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAGeMpyYxfpFnH2nppK8dBw== X-Mailru-Sender: 11C2EC085EDE56FAC71737E9F694C0DE8E4C261526128E18B43803229D7204F92712A73EED0DF0A1645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, LGTM On 31.08.2022 18:33, Igor Munkin wrote: > >>> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml >>> index 8c8dcff1..21d86764 100644 >>> --- a/.github/workflows/linux-aarch64.yml >>> +++ b/.github/workflows/linux-aarch64.yml >>> @@ -53,11 +53,15 @@ jobs: >>> sudo apt -y update >>> sudo apt -y install cmake gcc make perl >>> - name: configure >>> - run: cmake . ${{ matrix.CMAKEFLAGS }} >>> + run: > >>> + cmake -S . -B ${{ env.BUILDDIR }} >>> + ${{ matrix.CMAKEFLAGS }} >>> - name: build >>> run: cmake --build . --parallel >>> + working-directory: ${{ env.BUILDDIR }} >>> - name: test >>> run: cmake --build . --parallel --target test >>> + working-directory: ${{ env.BUILDDIR }} >> 1. I don't get an idea to use current dir for CMake and specify a >> working-directory in a job step. >> >> Why not "cmake --build ${{ env.BUILDDIR }}" as above? > I tried to not touch the original command. Configuration step can't be > left intact, but build and test -- can and that makes diff more clear > (IMHO). Furhermore, it looks more explicit to me: the command is run in > the current directory, and the current directory is specified > separately from the command itself. > >>> >>> test-tarantool-debug-w-GC64: >>> name: Tarantool Debug GC64:ON > >