From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B077046970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  7 Feb 2020 01:15:02 +0300 (MSK)
References: <4bfe72ac-ab2e-9832-d963-51bd181a27b4@tarantool.org>
 <20200204193040.61369-1-k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <f6b069bd-793c-944a-fa4d-20d3e50d8867@tarantool.org>
Date: Thu, 6 Feb 2020 23:15:01 +0100
MIME-Version: 1.0
In-Reply-To: <20200204193040.61369-1-k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/4] box: add binary search for
 _session_settings space
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch!

Here is one another review fix.

================================================================================

commit 0a597ec7e4956a23d5e80420ca1d98fccab8d117
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date:   Thu Feb 6 22:07:50 2020 +0100

    Review fix

diff --git a/test/box/gh-4511-access-settings-from-any-frontend.result b/test/box/gh-4511-access-settings-from-any-frontend.result
index f072bafae..bae77192e 100644
--- a/test/box/gh-4511-access-settings-from-any-frontend.result
+++ b/test/box/gh-4511-access-settings-from-any-frontend.result
@@ -86,7 +86,7 @@ function check_sorting(ss, ts, key)
             return {
                 err = 'bad sorting', type = it, exp = test_space,
                 got = view_space
-        }
+            }
         end
         for key, value in pairs(view_space) do
             if test_space[key].name ~= value.name then
diff --git a/test/box/gh-4511-access-settings-from-any-frontend.test.lua b/test/box/gh-4511-access-settings-from-any-frontend.test.lua
index 40a58ad04..b243be15e 100644
--- a/test/box/gh-4511-access-settings-from-any-frontend.test.lua
+++ b/test/box/gh-4511-access-settings-from-any-frontend.test.lua
@@ -40,7 +40,7 @@ function check_sorting(ss, ts, key)
             return {
                 err = 'bad sorting', type = it, exp = test_space,
                 got = view_space
-        }
+            }
         end
         for key, value in pairs(view_space) do
             if test_space[key].name ~= value.name then