From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A735824190 for ; Tue, 8 May 2018 12:02:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2kFBgljIl8wS for ; Tue, 8 May 2018 12:02:20 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6465624184 for ; Tue, 8 May 2018 12:02:20 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/2] sql: introduce sort order to key_part/key_part_def References: <83009edbb2f4bc03444630a9239d746792a69c06.1525765048.git.kyukhin@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Tue, 8 May 2018 19:02:17 +0300 MIME-Version: 1.0 In-Reply-To: <83009edbb2f4bc03444630a9239d746792a69c06.1525765048.git.kyukhin@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Yukhin Cc: tarantool-patches@freelists.org Hello. Thanks for contributing! See 2 comments below. 1. I still can grep SQLITE_SO_ASC/DESC in build.c On 08/05/2018 10:56, Kirill Yukhin wrote: > Legacy SQL DD structs contained sort_order, defined per > index column. During integration, those structs are to be > vanished. So, introduce new field to part entity of Tarantool. > This field states for sorting order of given part in give index. > This field is ignored by Tarantool everywhere excpept for > some of nested queries in SQL. > > Patch also replaces usages of SQL's stored sort order w/ this new > field. > > Part of #3235 > --- > src/box/key_def.cc | 28 ++++++++++++++++++++++------ > src/box/key_def.h | 16 +++++++++++++++- > src/box/schema.cc | 30 ++++++++++++++++++++---------- > src/box/sql.c | 11 +++++++++-- > src/box/sql/build.c | 47 ++++++++++++++++++++++++++++++++++++----------- > src/box/sql/expr.c | 9 ++++----- > src/box/sql/insert.c | 3 ++- > src/box/sql/parse.y | 10 +++++----- > src/box/sql/pragma.c | 7 ++++--- > src/box/sql/select.c | 2 +- > src/box/sql/sqliteInt.h | 20 ++++++++++++-------- > src/box/sql/vdbe.h | 1 + > src/box/sql/where.c | 11 ++++++----- > src/box/sql/wherecode.c | 10 ++++++---- > 14 files changed, 143 insertions(+), 62 deletions(-) > > diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h > index 8bb45c9..a811932 100644 > --- a/src/box/sql/sqliteInt.h > +++ b/src/box/sql/sqliteInt.h > @@ -3540,6 +3534,16 @@ sql_default_coll(); > bool > space_is_view(Table *); > > +/** > + * Return name of given column collation from index. 2. Irrelevant comment.