From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 39CC64696C3 for ; Fri, 28 Feb 2020 11:35:08 +0300 (MSK) From: Serge Petrenko Date: Fri, 28 Feb 2020 11:34:43 +0300 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v5 2/4] wal: warn when trying to write a record with a broken lsn List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: v.shpilevoy@tarantool.org Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't fire in release builds, of course. Let's at least warn the user on an attemt to write a record with a duplicate or otherwise broken lsn, and not follow such an lsn. Follow-up #4739 --- src/box/wal.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/box/wal.c b/src/box/wal.c index ac977c16e..27bff662a 100644 --- a/src/box/wal.c +++ b/src/box/wal.c @@ -951,9 +951,20 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base, (*row)->tsn = tsn; (*row)->is_commit = row == end - 1; } else { - vclock_follow(vclock_diff, (*row)->replica_id, - (*row)->lsn - vclock_get(base, - (*row)->replica_id)); + int64_t diff = (*row)->lsn - vclock_get(base, (*row)->replica_id); + if (diff <= vclock_get(vclock_diff, + (*row)->replica_id)) { + say_crit("Attempt to write a broken LSN to WAL:" + " replica id: %d, confirmed lsn: %d," + " new lsn %d", (*row)->replica_id, + vclock_get(base, (*row)->replica_id) + + vclock_get(vclock_diff, + (*row)->replica_id), + (*row)->lsn); + assert(false); + } else { + vclock_follow(vclock_diff, (*row)->replica_id, diff); + } } } } -- 2.21.1 (Apple Git-122.3)