From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EF3D243D678
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 22 Oct 2019 01:59:14 +0300 (MSK)
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reply-To: tarantool-patches@freelists.org
References: <cover.1568798455.git.georgy@tarantool.org>
 <68fa00546c99b7b53c1c3024881a19024513104d.1568798455.git.georgy@tarantool.org>
 <772fcc2b-bf03-19d1-6431-1b7d2b058865@tarantool.org>
Message-ID: <f484048b-4580-6523-ffed-828cb5d3ec00@tarantool.org>
Date: Tue, 22 Oct 2019 01:04:29 +0200
MIME-Version: 1.0
In-Reply-To: <772fcc2b-bf03-19d1-6431-1b7d2b058865@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/4] wal:
	wal memory buffer
List-Id: Tarantool development <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@freelists.org, Georgy Kirichenko <georgy@tarantool.org>, tarantool-patches@dev.tarantool.org

>> +enum {
>> +	/*
>> +	 * Xrow memory object contains some count of rotating data chunks.
>> +	 * Every rotation estimated decrease in amount of stored rows is
>> +	 * about 1/(COUNT OF CHUNKS). However the bigger value makes rotation
>> +	 * more frequent, the decrease would be smoother and size of
>> +	 * a wal memory more stable.
> 
> 27. Please, limit max length of a comment string to 66 symbols. It
> helps reading, no jokes. In the C file too.

Sorry, still out of 66. In many other places too.