From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E471B6EC58; Thu, 5 Aug 2021 02:58:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E471B6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628121512; bh=1Ho99oo7tDOsgNyTdKxWzqfmdzAeQhJiHcC2A3VIX9s=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UPG285F3eYrDhqQMUEIUbWh9uHkcB6suQdys44X/ArfpnIH05CCVUzNi8n2GcuvF8 sgTlo1v6TEZ9V6oYWDKhFc+va+cisgins2Mw1bdDqqUDSHkEkg2H6/zsDk00d2WKXZ ZIOKCwZQrCc2CIW4Vo9z7nai8UqErLfuHlpCMIRQ= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 345206EC58 for ; Thu, 5 Aug 2021 02:58:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 345206EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mBQmE-0001gS-1p; Thu, 05 Aug 2021 02:58:22 +0300 To: Timur Safin , olegrok@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Thu, 5 Aug 2021 01:58:21 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C36A98DBA789EBB6AE26DB9A6C1D9BF7E0182A05F53808504050D8E2547181421A1286823FDBFEC4D1D4A3BC24CD4FFE743FEBE9A466B15544 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AE0F15972A9DD0A8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D3A9DC970DD6E2F6EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2D5DC2E41FBBF0E8B7EF3FC77F25EC2CCCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2D576BCF940C736C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5053B71511467F72174CCA72E1251A2119C X-C1DE0DAB: 0D63561A33F958A5D1330CAF2C84BB4ECADDEDB2673B38C33EAF399613745113D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343FB425EC7F4D4A4BC09F3C45237CA43529A505C8739B35137BEE0DD69456F9C4BA4D0DF05465478B1D7E09C32AA3244C3739550CFFE0817E61D761EA6F96C8CA8894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3WEOjRDCnDHJA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D4437CC9A1E40D10CC34063B263202B753841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 1/9] build: add Christian Hansen c-dt to the build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! On 02.08.2021 02:40, Timur Safin via Tarantool-patches wrote: > * Integrated chansen/c-dt parser as 3rd party module to the > Tarantool cmake build process. > * Points to tsafin/c-dt instead iof original chansen/c-dt to > have easier build integration, because there is additional > commit which integrated cmake support As I said in the previous review, it points at https://github.com/tarantool/c-dt.git, not at tsafin/c-dt. Why do you keep saying the contrary? Look: url = https://github.com/tarantool/c-dt.git It is 'tarantool', not 'tsafin' here. Also, like on the previous review, when I call 'make' and do 'git status', I see: Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/c-dt (modified content, untracked content) You still didn't fix it. Please, do.