From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7B7E46EC58; Thu, 5 Aug 2021 11:55:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7B7E46EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628153756; bh=25g6UWs5f+QIMugqKuTjnwFk/owFORP2IHnqG/2d8aI=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=InFnqYHyRXCg4xqjIsXISRLuyGQtYd2WYquZ2GM/BfiMRQyObTyC7R8MwvVJ9kgZt XM9NXhMdnLCm/+lI8wpRLQXx7hchzCVQUKHHrmKtGSaQSuNKMf3hgdqNf7D+/j1bmH Uv5OZc5unsParSTuzZPBxXWETA2f0Nt4D374BGO8= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DDFCB6EC58 for ; Thu, 5 Aug 2021 11:55:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DDFCB6EC58 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1mBZAP-0004uZ-VB; Thu, 05 Aug 2021 11:55:54 +0300 To: Vladislav Shpilevoy , olegrok@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Thu, 5 Aug 2021 11:55:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3104FC76DFAAAAF7DA068FE323FAC4379182A05F53808504024184E732EBEC7CF7BEE6662594AEA95DA9CAA771D0B1965A664528E74ECCC36 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE788A2BECDB72C1542EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D08ED87D5614270A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D893E4D5C11E49FDA0EB772F22D77BAB44117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0F7F16001415B11694D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE39E541A154B51D14BBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5057380E46E8ACF5A8550F537E433ED3971 X-C1DE0DAB: 0D63561A33F958A580297DF0A7BD3A743BEFEB624A803A694E9D89C0D6C46342D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C1E32F4AD4B2486BAEB7DE191034ADBD130DFD6954477086DA452D057FF1EF6D8B542AFCA30B185A1D7E09C32AA3244C7C60E93F456EB8E011FF9D50C3729ED5795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3V7/Xa72XN5nA== X-Mailru-Sender: B5B6A6EBBD94DAD81091F6801AA03C0171F28688042111DD25FB91B7B623F21C04D5667F35E5B9D95C2808D6142752370A8ED71B308007E3DC85537438B7E1A423D748DE48713E689437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 1/9] build: add Christian Hansen c-dt to the build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Safin Timur via Tarantool-patches Reply-To: Safin Timur Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello Vlad! On 05.08.2021 2:58, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > On 02.08.2021 02:40, Timur Safin via Tarantool-patches wrote: >> * Integrated chansen/c-dt parser as 3rd party module to the >> Tarantool cmake build process. >> * Points to tsafin/c-dt instead iof original chansen/c-dt to >> have easier build integration, because there is additional >> commit which integrated cmake support > > As I said in the previous review, it points at > https://github.com/tarantool/c-dt.git, not at tsafin/c-dt. Why > do you keep saying the contrary? Look: > > url = https://github.com/tarantool/c-dt.git > > It is 'tarantool', not 'tsafin' here. Yes, that was oversight, due to several restarts of rebase session (I guess due to mess generated with combination of --autosquash and git rerere) Now finally applied to this commit in branch as commit #4b90de3bb21b9f28bc7c1f8e851d4c95f1b0f191. > > Also, like on the previous review, when I call 'make' and do > 'git status', I see: > > Changes not staged for commit: > (use "git add ..." to update what will be committed) > (use "git restore ..." to discard changes in working directory) > (commit or discard the untracked or modified content in submodules) > modified: third_party/c-dt (modified content, untracked content) > > You still didn't fix it. Please, do. > That was not a problem for me, due to the fact I _always_ use out-of-source build, and all artifacts generated separately under ${CMAKE_CURRENT_BINARY_DIR}/third_party/c-dt/, and such artifacts inside of source tree problem observed only when you do (not very idiomatic) in-source build. cmake generated Makefile overwrite original c-dt Makefile. [While we are here, could you please remind me why we recommend to use in-source build in our documentation? And not prefer the recommended and used by majority of industry for what matter out-of-source build?] We could rather may not influence how and where artifacts will be generated from inside of our own c-dt/CMakeLists.txt, we should rather modify the way how it get used, like, not include it via simple add_subdirectory(which is exactly defining this ${CMAKE_CURRENT_BINARY_DIR}/third_party/c-dt, which would be equal to ${CMAKE_CURRENT_SOURCE_DIR}/third_party/c-dt for in-source build, but rather use some ExternalProject_Add() techniques, which allows to redefine generated and binary files localtion. Let me check what is the easiest way here... Thanks, Timur