From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4C83B2B2C8 for ; Mon, 19 Nov 2018 05:10:04 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rNOdR7cSS4GZ for ; Mon, 19 Nov 2018 05:10:04 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A6C062A8F1 for ; Mon, 19 Nov 2018 05:10:03 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH] Disable triggers for _collation during bootstrap References: <20181115150421.24082-1-korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 19 Nov 2018 13:09:57 +0300 MIME-Version: 1.0 In-Reply-To: <20181115150421.24082-1-korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Nikita Pettik , tarantool-patches@freelists.org Hi! Thanks for the patch! LGTM. On 15/11/2018 18:04, Nikita Pettik wrote: > After patch that introduced "none" collation (a953051), > box.internal.bootstrap() started to fail due to inability to drop > mentioned collation. Lets turn off system triggers for _collation space > in order to process its complete purification during bootstrap. > --- > Branch: https://github.com/tarantool/tarantool/tree/np/none-collation-hotfix > > src/box/bootstrap.snap | Bin 1911 -> 1911 bytes > src/box/lua/upgrade.lua | 1 + > 2 files changed, 1 insertion(+) > > diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua > index 4b0fd0345..3d9acc976 100644 > --- a/src/box/lua/upgrade.lua > +++ b/src/box/lua/upgrade.lua > @@ -70,6 +70,7 @@ local function set_system_triggers(val) > box.space._func:run_triggers(val) > box.space._priv:run_triggers(val) > box.space._trigger:run_triggers(val) > + box.space._collation:run_triggers(val) > end > > -------------------------------------------------------------------------------- >