From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9391B28980 for ; Mon, 13 Aug 2018 16:24:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oRpUIx6fuWmj for ; Mon, 13 Aug 2018 16:24:31 -0400 (EDT) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5331028910 for ; Mon, 13 Aug 2018 16:24:31 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 07/10] sql: remove index type from struct Index References: From: Vladislav Shpilevoy Message-ID: Date: Mon, 13 Aug 2018 23:24:28 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! I have pushed my review fixes in a separate commit. The most significant change - I have inlined sql_index_is_unique since index's is_unique flag is intuitive enough to understand what is being checked. Also I have reduced primary index getting to just returning of the first index in pTable->pIndex list like it is done in struct space. And this patch passes the tests. But next started failing. Please, investigate why. Looks like you started inserting primary index not in the list head. On 12/08/2018 17:13, Nikita Pettik wrote: > Part of #3561 > --- > src/box/sql.c | 2 +- > src/box/sql/analyze.c | 2 +- > src/box/sql/build.c | 92 +++++++++++++++++++------------------------------ > src/box/sql/insert.c | 14 ++++---- > src/box/sql/pragma.c | 7 +--- > src/box/sql/prepare.c | 9 +---- > src/box/sql/sqliteInt.h | 18 ++++------ > src/box/sql/update.c | 2 +- > src/box/sql/where.c | 4 +-- > src/box/sql/wherecode.c | 4 +-- > 10 files changed, 58 insertions(+), 96 deletions(-) >