From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7F5BD26B78 for ; Tue, 3 Apr 2018 13:23:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NTWPF7kZwnni for ; Tue, 3 Apr 2018 13:23:26 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 40F5026B55 for ; Tue, 3 Apr 2018 13:23:26 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/3] sql: remove usless #ifdef directives References: <36f222edde4edcd81e544a2c3e83c5b0aef721bd.1522763649.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Tue, 3 Apr 2018 20:23:21 +0300 MIME-Version: 1.0 In-Reply-To: <36f222edde4edcd81e544a2c3e83c5b0aef721bd.1522763649.git.korablev@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Nikita Pettik Hello. Please consider a single comment: remove SQLITE_OMIT_VIEW from mkkeywordhash.c. Other comments I will give to a next patch version, as we discussed verbally. 03.04.2018 17:54, Nikita Pettik пишет: > Since in our SQL implemetation triggers, foreign keys and views are > always available, there is no need in #ifdef directives which > turn them off. > Removed: SQLITE_OMIT_VIEW, SQLITE_OMIT_TRIGGER, SQLITE_OMIT_FOREIGN_KEY > defines. Also, removed obsolete compelete.c source file. > --- > src/box/sql/CMakeLists.txt | 1 - > src/box/sql/alter.c | 2 - > src/box/sql/attach.c | 6 - > src/box/sql/build.c | 20 --- > src/box/sql/complete.c | 333 --------------------------------------------- > src/box/sql/delete.c | 18 --- > src/box/sql/expr.c | 5 +- > src/box/sql/fkey.c | 8 -- > src/box/sql/insert.c | 15 -- > src/box/sql/parse.c | 320 +++++++++++++++++++++---------------------- > src/box/sql/parse.y | 7 - > src/box/sql/pragma.c | 8 -- > src/box/sql/pragma.h | 8 -- > src/box/sql/resolve.c | 3 - > src/box/sql/select.c | 20 ++- > src/box/sql/sqliteInt.h | 39 ------ > src/box/sql/treeview.c | 2 - > src/box/sql/trigger.c | 3 - > src/box/sql/update.c | 15 -- > src/box/sql/vdbe.c | 5 - > src/box/sql/vdbe.h | 2 - > src/box/sql/vdbeInt.h | 4 - > src/box/sql/vdbeaux.c | 4 - > 23 files changed, 169 insertions(+), 679 deletions(-) > delete mode 100644 src/box/sql/complete.c >