From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B90F4469710 for ; Mon, 1 Jun 2020 20:03:58 +0300 (MSK) References: <92fc506a755863ccdf807b232dca5b96737708c6.1590671266.git.imeevma@gmail.com> From: Vladislav Shpilevoy Message-ID: Date: Mon, 1 Jun 2020 19:03:57 +0200 MIME-Version: 1.0 In-Reply-To: <92fc506a755863ccdf807b232dca5b96737708c6.1590671266.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 2/6] sql: remove mem_apply_type() from OP_MakeRecord List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mergen Imeev , tsafin@tarantool.org, tarantool-patches@dev.tarantool.org Thanks for the patch! > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index 2a941025c..fc41ee0d6 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -2902,7 +2902,6 @@ case OP_CheckType: { > * into ephemeral space. Thus, sort of memory optimization can be performed. > */ P4 should be removed from the comment too. > case OP_MakeRecord: { > - Mem *pRec; /* The new record */ > Mem *pData0; /* First field to be combined into the record */ > Mem MAYBE_UNUSED *pLast; /* Last field of the record */ > int nField; /* Number of fields in the record */