From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0F86C41C5DA for ; Thu, 25 Jun 2020 01:22:43 +0300 (MSK) References: <7e17dc729687c7c61da5f761e4302e6e78b9d01f.1593017012.git.k.sosnin@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 25 Jun 2020 00:22:41 +0200 MIME-Version: 1.0 In-Reply-To: <7e17dc729687c7c61da5f761e4302e6e78b9d01f.1593017012.git.k.sosnin@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v2 1/2] Refactor decNumberFromString List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin , tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org Hi! Thanks for the patch! Technically looks fine, although I didn't test it except for the tests we already have. You probably should create a patchset for the main repository with decnumber version bump + decimal.h API update + unit tests in unit/decimal.c. Before this commit is merged, so as you could fix any potential errors. > diff --git a/decNumber.c b/decNumber.c > index 85deb13..e248656 100644 > --- a/decNumber.c > +++ b/decNumber.c > @@ -545,7 +545,7 @@ char * decNumberToEngString(const decNumber *dn, char *string){ > /* */ > /* If bad syntax is detected, the result will be a quiet NaN. */ > /* ------------------------------------------------------------------ */ > -decNumber * decNumberFromString(decNumber *dn, const char chars[], > +const char * decNumberFromString(decNumber *dn, const char chars[], > decContext *set) { 1. The code style is absolutely dead, but it is consistently dead. Part of its consistency was the multi-line argument alignment, the same as in Tarantool. Here the second line should be aligned under the first argument of the first line: const char * decNumberFromString(decNumber *dn, const char chars[], decContext *set) { Not like this: const char * decNumberFromString(decNumber *dn, const char chars[], decContext *set) { > diff --git a/decNumber.h b/decNumber.h > index 85a3f3f..ffaa3d8 100644 > --- a/decNumber.h > +++ b/decNumber.h > @@ -101,19 +101,19 @@ > /* decNumber public functions and macros */ > /* ---------------------------------------------------------------- */ > /* Conversions */ > - decNumber * decNumberFromInt32(decNumber *, int32_t); > - decNumber * decNumberFromUInt32(decNumber *, uint32_t); > - decNumber * decNumberFromInt64(decNumber *, int64_t); > - decNumber * decNumberFromUInt64(decNumber *, uint64_t); > - decNumber * decNumberFromString(decNumber *, const char *, decContext *); > - char * decNumberToString(const decNumber *, char *); > - char * decNumberToEngString(const decNumber *, char *); > - uint32_t decNumberToUInt32(const decNumber *, decContext *); > - uint64_t decNumberToUInt64(const decNumber *, decContext *); > - int32_t decNumberToInt32(const decNumber *, decContext *); > - int64_t decNumberToInt64(const decNumber *, decContext *); > - uint8_t * decNumberGetBCD(const decNumber *, uint8_t *); > - decNumber * decNumberSetBCD(decNumber *, const uint8_t *, uint32_t); > + decNumber * decNumberFromInt32(decNumber *, int32_t); > + decNumber * decNumberFromUInt32(decNumber *, uint32_t); > + decNumber * decNumberFromInt64(decNumber *, int64_t); > + decNumber * decNumberFromUInt64(decNumber *, uint64_t); > + const char * decNumberFromString(decNumber *, const char *, decContext *); > + char * decNumberToString(const decNumber *, char *); > + char * decNumberToEngString(const decNumber *, char *); > + uint32_t decNumberToUInt32(const decNumber *, decContext *); > + uint64_t decNumberToUInt64(const decNumber *, decContext *); > + int32_t decNumberToInt32(const decNumber *, decContext *); > + int64_t decNumberToInt64(const decNumber *, decContext *); > + uint8_t * decNumberGetBCD(const decNumber *, uint8_t *); > + decNumber * decNumberSetBCD(decNumber *, const uint8_t *, uint32_t); 2. Lets not do so many changes. I think it is ok to break the alignment in one line. Or you can wrap function name on a next line, if you want. So as it would be decNumber * decNumberFromUInt64(decNumber *, uint64_t); const char * decNumberFromString(decNumber *, const char *, decContext *); char * decNumberToString(const decNumber *, char *); Or break the alignment: decNumber * decNumberFromUInt64(decNumber *, uint64_t); const char * decNumberFromString(decNumber *, const char *, decContext *); char * decNumberToString(const decNumber *, char *); But I really don't like when alignment causes so many changes.