From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BB44ED5DEEF; Wed, 13 Mar 2024 11:56:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BB44ED5DEEF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1710320203; bh=14qE2NxXVYjin2fHbrPJtyvykqgWrWjQrYPZD9SlG7U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MKHpKiQt6s/hk3X8Nzl+2pZla4l/ZgpE9hfIvG+D0r7EANFOzj90Jf0/4mJJvMPFc FU9sDwuYL0hvr1nvAuDVf7xzCbT1g1UNmprNtIbHpIfMrbSrHxRzw7l3ULviIC6ETo x0vdRVeIteAzvs7R0kiiUjI20MLOyA08TWoB+QFA= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [95.163.41.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DC6C0D5DEEF for ; Wed, 13 Mar 2024 11:56:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DC6C0D5DEEF Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1rkKPi-00000003zHP-0SRV; Wed, 13 Mar 2024 11:56:42 +0300 Date: Wed, 13 Mar 2024 11:56:41 +0300 To: Sergey Bronnikov Message-ID: References: <93809031fbffd82c29538d652c4418e12db7baaf.1710251441.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93809031fbffd82c29538d652c4418e12db7baaf.1710251441.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597D21AFE2E000C69B1FBAF020A234192257182A05F538085040B1C90226FC04D184A6D5EE0DB6E1EC8D6AC0351A54EB7E965846D4743633293393E494D66C88D90D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB6A86BDF2D5A895EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372E9841F416E2DCCD8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B7017984DE6EEB0B2762CFA3F7ED47CA5D77CF8076AD4F8CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D8803F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C325C33BDE98D8A053BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C34B08FA16E56A400835872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5D0BC56CC3A98ED745002B1117B3ED696B1C2E8C84404A7E95B6221DB6D7A72AD823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF64B85BF87FC98A2D6D2195BD2DFF16E166F62A0AE3F943C18F8FF557A98CECB204D7482423E9A0B87C77D8D956826D335573521ECF1029FB5CA469DC24CDBE25F592E8376D01E71EC226CC413062362A913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtv/CB9kl0S03GiQ8lQ6aTA== X-Mailru-Sender: 7940E2A4EB16C9976F80DCDCD59EC227A6846B0377DF7873A6D5EE0DB6E1EC8D6AC0351A54EB7E96E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a few nits regarding the commit message. On Tue, Mar 12, 2024 at 04:51:02PM +0300, Sergey Bronnikov wrote: > From: Sergey Bronnikov Patch header contains a typo. Typo: s/c:/ci:/ > > Bump version of actions/checkout to v4. > Bump fixes an annoying warning that appears in Github WebUI: Typo: s/in/in the/ > > Node.js 16 actions are deprecated. Please update the following actions > to use Node.js 20: actions/checkout@v3. For more information see: > https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. It would be nicer to emphasize the message with | on each line: | Node.js 16 actions are deprecated. Please update the following actions | to use Node.js 20: actions/checkout@v3. For more information see: | https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. > --- > .github/workflows/coverage.yml | 2 +- > .github/workflows/exotic-builds-testing.yml | 2 +- > .github/workflows/gnumake-builds-testing.yml | 2 +- > .github/workflows/lint.yml | 2 +- > .github/workflows/sanitizers-testing.yml | 2 +- > .github/workflows/testing.yml | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) >