From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EE5B1469719 for ; Mon, 12 Oct 2020 11:51:39 +0300 (MSK) References: <20201008215956.93983-1-roman.habibov@tarantool.org> From: Leonid Vasiliev Message-ID: Date: Mon, 12 Oct 2020 11:51:29 +0300 MIME-Version: 1.0 In-Reply-To: <20201008215956.93983-1-roman.habibov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/2] Improve json error message. List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Khabibov , tarantool-patches@dev.tarantool.org Hi! Thank you for the patch. Add @ChangeLog. On 09.10.2020 00:59, Roman Khabibov wrote: > I already have LGTM from Vlad. > > Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4339-json-err > Issue: https://github.com/tarantool/tarantool/issues/4339 > > Roman Khabibov (2): > json: make error messages more readable > json: print context in error mesages > > test/app-tap/json.test.lua | 50 +++++++++++++++- > third_party/lua-cjson/lua_cjson.c | 97 +++++++++++++++++++++++-------- > 2 files changed, 122 insertions(+), 25 deletions(-) >