From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 04B3C24DA3
	for <tarantool-patches@freelists.org>; Mon,  5 Aug 2019 17:13:47 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id GuZDdwSRiToX for <tarantool-patches@freelists.org>;
	Mon,  5 Aug 2019 17:13:46 -0400 (EDT)
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 51B8824D94
	for <tarantool-patches@freelists.org>; Mon,  5 Aug 2019 17:13:46 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 2/3] box: stacked diagnostics area
 in fiber
References: <cover.1564657285.git.kshcherbatov@tarantool.org>
 <0788e7745432f2ff59be4578db0daf0c632900ed.1564657285.git.kshcherbatov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ef1f672c-b80c-1e1b-86c4-5a96143cc826@tarantool.org>
Date: Mon, 5 Aug 2019 23:16:06 +0200
MIME-Version: 1.0
In-Reply-To: <0788e7745432f2ff59be4578db0daf0c632900ed.1564657285.git.kshcherbatov@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: alexander.turenko@tarantool.org, kostja@tarantool.org

Thanks for the patch! See 2 comments below.

On 01/08/2019 13:13, Kirill Shcherbatov wrote:
> This patch introduces stacked errors. A new API diag_add allows
> to extend an existent error information with a new one error.

1. 'a' assumes singular. You can and usually should omit 'one'.

> The previous state becomes a "reason" of the last-set error.
> Each error object takes a reference to it's reason error object.
> 
> The :unpack() method patched correspondingly to display the whole
> errors trace.
> 
> Part of #1148
> ---
> diff --git a/test/engine/func_index.result b/test/engine/func_index.result
> index 877b76d5e..ae8873c9b 100644
> --- a/test/engine/func_index.result
> +++ b/test/engine/func_index.result
> @@ -189,6 +188,16 @@ s:insert({1})
>   | - error: 'Key format doesn''t match one defined in functional index ''idx'' of space
>   |     ''withdata'': to many values were returned'
>   | ...
> +box.error.last():unpack()
> + | ---
> + | - - type: ClientError
> + |     code: 199
> + |     message: 'Key format doesn''t match one defined in functional index ''idx'' of
> + |       space ''withdata'': to many values were returned'
> + |     trace:
> + |     - file: /home/kir/WORK/tarantool/src/box/key_list.c
> + |       line: 95

2. Firstly, if you change something on the branch, then please, write about in an email.
On the branch I see that you added filters. Lets filter out the line as well. Otherwise
that test will fail each time we add or delete any of first 95 lines of key_list.c.

> + | ...
>  idx:drop()
>   | ---
>   | ...