From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 770584696C2
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 21 Nov 2020 17:41:17 +0300 (MSK)
References: <cover.1605629206.git.sergeyb@tarantool.org>
 <ada63b17702e8be6f223788368309767228b8102.1605629206.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ef12777e-2cd9-af63-8352-93477246f3c6@tarantool.org>
Date: Sat, 21 Nov 2020 15:41:16 +0100
MIME-Version: 1.0
In-Reply-To: <ada63b17702e8be6f223788368309767228b8102.1605629206.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 4/4] replication: add test with
 change space sync mode in a loop
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org

Thanks for the patch!

> +++ b/test/replication/qsync_sync_mode.result
> @@ -0,0 +1,114 @@
> +-- test-run result file version 2
> +env = require('test_run')
> + | ---
> + | ...
> +test_run = env.new()
> + | ---
> + | ...
> +engine = test_run:get_cfg('engine')
> + | ---
> + | ...
> +fiber = require('fiber')
> + | ---
> + | ...
> +math = require('math')
> + | ---
> + | ...
> +
> +orig_synchro_quorum = box.cfg.replication_synchro_quorum
> + | ---
> + | ...
> +orig_synchro_timeout = box.cfg.replication_synchro_timeout
> + | ---
> + | ...
> +
> +math.randomseed(os.time())
> + | ---
> + | ...
> +random_boolean = function()                                                    \
> +    if (math.random(1, 10) > 5) then                                           \

In Lua we don't use () in if conditions. Also you could simply
'return math.random(1, 10) > 5'.

> +        return true                                                            \
> +    else                                                                       \
> +        return false                                                           \
> +    end                                                                        \
> +end