From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A4AC2469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 21 May 2020 00:57:07 +0300 (MSK)
References: <cover.1589240704.git.v.shpilevoy@tarantool.org>
 <22a830fb9d2dbc3883b9710d36ab88c638101002.1589240704.git.v.shpilevoy@tarantool.org>
 <20200513123145.GA16814@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ef0858a0-e417-2dc6-cbd5-72eb3b188429@tarantool.org>
Date: Wed, 20 May 2020 23:57:05 +0200
MIME-Version: 1.0
In-Reply-To: <20200513123145.GA16814@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR
	extension serializer
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

I added explicit casts when print uint64 in mp_error.cc,
since some compilers complain about %lld != uint64_t, as
noticed by Alexander T.

====================
diff --git a/src/box/mp_error.cc b/src/box/mp_error.cc
index badf7ee92..61cf5e1b8 100644
--- a/src/box/mp_error.cc
+++ b/src/box/mp_error.cc
@@ -657,7 +657,7 @@ mp_print_error_one(MP_PRINT_ARGS_DECL, const char **data, int depth)
 		if (key < MP_ERROR_MAX)
 			MP_PRINT(total, "%s", mp_error_field_to_json_key[key]);
 		else
-			MP_PRINT(total, "%llu: ", key);
+			MP_PRINT(total, "%llu: ", (unsigned long long)key);
 		MP_PRINT_2(total, mp_print_common, data, depth);
 	}
 	MP_PRINT(total, "}");
@@ -717,7 +717,7 @@ mp_print_error(MP_PRINT_ARGS_DECL, const char **data, int depth)
 			break;
 		}
 		default:
-			MP_PRINT(total, "%llu: ", key);
+			MP_PRINT(total, "%llu: ", (unsigned long long)key);
 			MP_PRINT_2(total, mp_print_common, data, depth);
 			break;
 		}