From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8ECCCC5B457; Thu, 15 Aug 2024 16:57:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8ECCCC5B457 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1723730270; bh=yozn0M0z7/GZlIcvf9FtdP3TPYqW+I+1qYFicO3VHX8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IBZHdAQblDsUV9xXfKbUsoCQVyhdPAItxRxp++18E1c/UuwHhvWespU5fRFMphr6j uVs1EYyzxLDOeR+lahnJt2kX4NNXeXqXrHGnIg4vAtvqc4746H9N8SW6YkKa8EBykj 6OEZgdsqgGHgHwdZi1zJF9+IkatZLBb6L8ABd2T8= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 068D1C5B457 for ; Thu, 15 Aug 2024 16:57:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 068D1C5B457 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1seaz6-000000059X6-1Nvj; Thu, 15 Aug 2024 16:57:48 +0300 Content-Type: multipart/alternative; boundary="------------h5aZU0w3qTJ0rXaX0AJW8oz1" Message-ID: Date: Thu, 15 Aug 2024 16:57:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <2b6a33d6518c6e441051469a800103a4111bfb75.1723638851.git.skaplun@tarantool.org> In-Reply-To: <2b6a33d6518c6e441051469a800103a4111bfb75.1723638851.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F97E3C14763C38E249236267832B8ADA0B40D94542519B7F182A05F538085040E7F13D4630FB8CC2D27678DDAA8063140CBF739BEF94E36F3BA737C44E88F1679A19E549D04913BF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE752E71F0C64B7C834EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459436292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81D54B91A92346537A18886B0DC8E97917A8550D3FD7CAF5CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063790495A4AD0498982D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE72B056A9979167638EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CE9959E2676FD87735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A50401369B463678ED5002B1117B3ED69679B8ABE6A0A2DE3F108A05421C070DB8823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFB20179CDD2DCCB8FD472129B0F21792C1421099B9A96858B5F0CC14A587D03257D7FE2FA29F57787470327EB0AC8E6935796F7ACDA57ED4F83558F881E9C911924F8C62CDC59097E5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojD5rM0r3KxnGChS0X/MZ0lA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140D7BE71AC6BBB8F7AA0122BF41C7A6963DE6034013D8F6A700152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 15/36] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------h5aZU0w3qTJ0rXaX0AJW8oz1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! Thanks for the patch! On 14.08.2024 16:55, Sergey Kaplun wrote: > This patch moves the aforementioned test from the to the > directory, includes it in , and names the subtest. +formatting changes > > The test is adjusted to be runable in the test suite by adding the > `jit.flush()` to avoid collisions of traces. Also, the number of > iterations for the compiled loop inside the hook is increased to avoid > hotcount collisions. > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/misc/hook_record.lua | 8 -------- > test/LuaJIT-tests/trace/hook_record.lua | 7 +++++++ > test/LuaJIT-tests/trace/index | 1 + > 3 files changed, 8 insertions(+), 8 deletions(-) > delete mode 100644 test/LuaJIT-tests/misc/hook_record.lua > create mode 100644 test/LuaJIT-tests/trace/hook_record.lua > > diff --git a/test/LuaJIT-tests/misc/hook_record.lua b/test/LuaJIT-tests/misc/hook_record.lua > deleted file mode 100644 > index 6f1646de..00000000 > --- a/test/LuaJIT-tests/misc/hook_record.lua > +++ /dev/null > @@ -1,8 +0,0 @@ > - > -if not jit or not jit.status or not jit.status() then return end > - > -debug.sethook(function() for i=1,100 do end end, "", 10) > -for i=1,10 do end > -debug.sethook() > -assert((require("jit.util").traceinfo(1))) > - > diff --git a/test/LuaJIT-tests/trace/hook_record.lua b/test/LuaJIT-tests/trace/hook_record.lua > new file mode 100644 > index 00000000..684e1139 > --- /dev/null > +++ b/test/LuaJIT-tests/trace/hook_record.lua > @@ -0,0 +1,7 @@ > +do --- Recording traces inside the hook. > + jit.flush() > + debug.sethook(function() for _ = 1, 1000 do end end, "", 10) > + for _ = 1, 10 do end > + debug.sethook() > + assert((require("jit.util").traceinfo(1))) > +end > diff --git a/test/LuaJIT-tests/trace/index b/test/LuaJIT-tests/trace/index > index 595a71d2..63af7870 100644 > --- a/test/LuaJIT-tests/trace/index > +++ b/test/LuaJIT-tests/trace/index > @@ -4,6 +4,7 @@ exit_jfuncf.lua > gc.lua > gc64_slot_revival.lua > hook_norecord.lua > +hook_record.lua > phi > snap.lua > stitch.lua --------------h5aZU0w3qTJ0rXaX0AJW8oz1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

Thanks for the patch!

On 14.08.2024 16:55, Sergey Kaplun wrote:
This patch moves the aforementioned test from the <misc> to the <trace/>
directory, includes it in <index>, and names the subtest.
+formatting changes

The test is adjusted to be runable in the test suite by adding the
`jit.flush()` to avoid collisions of traces. Also, the number of
iterations for the compiled loop inside the hook is increased to avoid
hotcount collisions.

Part of tarantool/tarantool#9398
---
 test/LuaJIT-tests/misc/hook_record.lua  | 8 --------
 test/LuaJIT-tests/trace/hook_record.lua | 7 +++++++
 test/LuaJIT-tests/trace/index           | 1 +
 3 files changed, 8 insertions(+), 8 deletions(-)
 delete mode 100644 test/LuaJIT-tests/misc/hook_record.lua
 create mode 100644 test/LuaJIT-tests/trace/hook_record.lua

diff --git a/test/LuaJIT-tests/misc/hook_record.lua b/test/LuaJIT-tests/misc/hook_record.lua
deleted file mode 100644
index 6f1646de..00000000
--- a/test/LuaJIT-tests/misc/hook_record.lua
+++ /dev/null
@@ -1,8 +0,0 @@
-
-if not jit or not jit.status or not jit.status() then return end
-
-debug.sethook(function() for i=1,100 do end end, "", 10)
-for i=1,10 do end
-debug.sethook()
-assert((require("jit.util").traceinfo(1)))
-
diff --git a/test/LuaJIT-tests/trace/hook_record.lua b/test/LuaJIT-tests/trace/hook_record.lua
new file mode 100644
index 00000000..684e1139
--- /dev/null
+++ b/test/LuaJIT-tests/trace/hook_record.lua
@@ -0,0 +1,7 @@
+do --- Recording traces inside the hook.
+  jit.flush()
+  debug.sethook(function() for _ = 1, 1000 do end end, "", 10)
+  for _ = 1, 10 do end
+  debug.sethook()
+  assert((require("jit.util").traceinfo(1)))
+end
diff --git a/test/LuaJIT-tests/trace/index b/test/LuaJIT-tests/trace/index
index 595a71d2..63af7870 100644
--- a/test/LuaJIT-tests/trace/index
+++ b/test/LuaJIT-tests/trace/index
@@ -4,6 +4,7 @@ exit_jfuncf.lua
 gc.lua
 gc64_slot_revival.lua
 hook_norecord.lua
+hook_record.lua
 phi
 snap.lua
 stitch.lua
--------------h5aZU0w3qTJ0rXaX0AJW8oz1--