From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EE93C469711 for ; Wed, 10 Jun 2020 01:29:53 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: Date: Wed, 10 Jun 2020 00:29:52 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 6/6] sql: remove OP_ApplyType List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mergen Imeev , tsafin@tarantool.org, tarantool-patches@dev.tarantool.org Thanks for the patch! > diff --git a/src/box/sql/wherecode.c b/src/box/sql/wherecode.c > index 1d7c76670..1ec9f4ed7 100644 > --- a/src/box/sql/wherecode.c > +++ b/src/box/sql/wherecode.c > @@ -571,7 +571,7 @@ codeEqualityTerm(Parse * pParse, /* The parsing context */ > * > * Before returning, @types is set to point to a buffer containing a > * copy of the column types array of the index allocated using > - * sqlDbMalloc(). This array is passed to OP_ApplyType to provide > + * sqlDbMalloc(). This array is passed to OP_CheckType to provide @types parameter does not exist anymore. I guess it was removed in one of the previous commits, and the comment should be updated there too. > * correct implicit conversions. > */ > static int