From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 0/5] JSON update preparation References: <20190731121531.GN4659@esperanza> From: Vladislav Shpilevoy Message-ID: Date: Wed, 31 Jul 2019 22:36:06 +0200 MIME-Version: 1.0 In-Reply-To: <20190731121531.GN4659@esperanza> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Vladimir Davydov Cc: tarantool-patches@freelists.org, Kirill Yukhin List-ID: I can't believe that you've watched this huge patchset, and don't have a single comment. But ok, understandable. Kirill, I've rebased it, made a couple of minor changes, and force pushed to the branch. You can merge, or propose who else could review this. On 31/07/2019 14:15, Vladimir Davydov wrote: > On Sun, Jul 14, 2019 at 12:11:03AM +0200, Vladislav Shpilevoy wrote: >> The patchset is mainly about rope and its usage. Rope is a data structure >> allowing to modify an array with memory overhead not depending on the array >> size. Only on the number of modifications. It is used when there is a long >> array of something, and a one wants to insert new elements, delete existing >> ones, change their values, but do not rebuild the whole array each time. >> >> Rope is going to be one of the core data structures of the incoming JSON path >> updates, and this patchset makes it faster and lighter. >> >> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-prepare >> Issue: https://github.com/tarantool/tarantool/issues/1261 >> >> Vladislav Shpilevoy (5): >> tuple: remove alloc and alloc_ctx args from update() >> rope: make rope library macro template >> tuple: relax struct tuple_update dependency on rope >> int96: add a missing header >> tuple: implement update by field name > > LGTM >