From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7ED5D6F15B; Mon, 22 Aug 2022 16:00:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7ED5D6F15B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1661173224; bh=M6yo5novqBjOMFKPBlaKu7gJTek4LLVrV7DS6tBZITA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=H7QTNvL0IHo6XUFEnu9eCqCyzt+qZll+CPzITtozWN/8ex8li3sQbAI60qti1bVhO zHCxsFe+c55kG3thHaK4PUlLnK5jQORQULJkxTUIYEpF6JQGNHM8+O0yNBdeuTcc3y MFgYTwlsCFR2VNfgws2k5SRjce1dJCUDP7RnDcY8= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E8ED16F15B for ; Mon, 22 Aug 2022 16:00:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E8ED16F15B Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1oQ72U-0003AE-8D; Mon, 22 Aug 2022 16:00:22 +0300 Message-ID: Date: Mon, 22 Aug 2022 16:00:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Sergey Kaplun , Mikhail Elhimov Cc: tarantool-patches@dev.tarantool.org References: <9eaffd397e8ebb3ccb898d50686249b9edd3f02f.1658531255.git.m.elhimov@vk.team> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD999D8F08CF16C6CA73AD8F82353FEF3B5A1325296CC59BB6F00894C459B0CD1B9A339712E96E108069E82BE1E2AFADC23367F5BBD7FF29D49EFBA94EB484632BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D8F5094E9BAC3E9F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8948FA5F2AF6D4399E3D8BBD3642CED226F9789CCF6C18C3F8528715B7D10C86878DA827A17800CE7A6779F98BF527B7A9FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B55D5BE2F85BDEC5FA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCC7A735BA0D550A223AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F79006375E36ACCF4CD39C50D81D268191BDAD3D698AB9A7B718F8C4D1B931868CE1C5781A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FC69DAE731B0060BD42539A7722CA490CB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0F56C66D0505D9834D9A1D0B5FC830B80797D1A42EBF837D3AF706BF2E0EE1C799C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3451BBE684D17D72218F3A29380870912C1D5A7A3EB059E0934AB985CBA888727F54C11A150BE470451D7E09C32AA3244C3D6CE330D5394B76AB220AD67E72A714725D5B54B2FE4575FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojq6mpPMt02jjln7fc7C8tNA== X-Mailru-Sender: 391A9C92F0A95CC617713B38CE9D64BB23CCACC84628BCB837E28DC169571D02D1782EF084D872BC893A38EEAA9F8901AD583E2F744EC1B103B957AC4C054F678DF4F02B79026D381B698827755E8382E5AA6234683BE64C3DDE9B364B0DF289AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] gdb: adjust to support python2 (centos 7) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mikhail Elhimov via Tarantool-patches Reply-To: Mikhail Elhimov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 20.08.2022 09:26, Sergey Kaplun wrote: > Hi, Mikhail! > > Thanks for the patch! > Sorry, for such long waiting. > It's LGTM, except a few stylish comments regarding the commit message. > > On 23.07.22, Mikhail Elhimov via Tarantool-patches wrote: >> Stop using unpacking arguments within list initialization as python2 > Typo: s/list initialization/the list initialization/ > Also, you may mention that this problem affected Lua stack dump. Fixed > >> only supports it in function call > Typo: s/function call/a function call/ > > Missed dot at the end of the sentence. Fixed > >> fixes tarantool/luajit#7458 > Typo: > Fixes tarantool/tarantool#7458 Fixed > >> --- >> src/luajit-gdb.py | 22 ++++++++++++---------- >> 1 file changed, 12 insertions(+), 10 deletions(-) >> >> diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py >> index baf66f66..1e9a96fb 100644 >> --- a/src/luajit-gdb.py >> +++ b/src/luajit-gdb.py > > >> -- >> 2.34.1 >> The corrected commit message: ================================================= gdb: adjust to support python2 (centos 7) Stop using unpacking arguments within the list initialization as python2 only supports it in a function call (it affected Lua stack dump). Fixes tarantool/tarantool#7458 ================================================= -- Best regards, Mikhail Elhimov