From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD2FE430408 for ; Wed, 12 Aug 2020 23:10:15 +0300 (MSK) References: <20200806131955.3400088-1-yaroslav.dynnikov@tarantool.org> <4a43127c-6e11-8f28-27ee-62e24fa65a4b@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Wed, 12 Aug 2020 22:10:13 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] Ensure all curl symbols are exported List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yaroslav Dynnikov Cc: tml , Alexander Turenko On 12.08.2020 14:59, Yaroslav Dynnikov wrote: > Hi, Vlad. > > Number 7 is the libcurl age. According to the documentation, age should be set to the version of this functionality by the time you write your program. This way, libcurl will always return a proper struct that your program understands, while programs in the future might get a different struct. See https://curl.haxx.se/libcurl/c/curl_version_info.html > > So it's safe enough to rely on the structure. And I think both checkes (libssl and libz) are important enough to be tracked by tests. We don't want them to be silently gone, do we? Still the test is overcomplicated, I think. But at least it should be stable, if with the same age number all curl versions will return the same curl_version_info_data. LGTM.