From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D07856EC5D; Thu, 8 Apr 2021 16:42:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D07856EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617889377; bh=K4aVrBHXVkdzIgHZgD5VxvXudk8MNIqHtkVwU6gZiKI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lv79c9xd/fHGjNrZrrOeNOOEDDRkNq4TXI3i52c2UKISCrFXz7iCynC4LQGQ6ucDO vdJWBifkGIPpVqiwrzbnQg7Yep1R8+o34Op+Q5Hfp+9b03k9ZCz+RbPwAaxzUzgH56 q6pxliJisDYeZamIM/YQGu/2wOZ5r6SFV8SA8mUQ= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C15B36EC60 for ; Thu, 8 Apr 2021 16:41:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C15B36EC60 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lUUuf-0000gw-To; Thu, 08 Apr 2021 16:41:38 +0300 To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Date: Thu, 8 Apr 2021 16:38:40 +0300 Message-Id: X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC171AADCC0319DEE4F527435CB409D56B200894C459B0CD1B92A32012DC5F31186CAE6BA5A3D3EB1CD38DE5FFF3BE30100B69AF26CEA7F1A08 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BAE5222749FC9020C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE749E89BD568380EEC8F08D7030A58E5ADC58D69EE07B14084F39EFFDF887939037866D6147AF826D8408C436DDBCFF0B3BBA9AAA4DBA511C0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC081CF0AE924DC023A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BC7BDA4D3A4672FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975CD0035DD76F8A8A4F3FCCDEA6CDB011CB5BA167A365708FE89C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EF0417BEADF48D1460699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454548929AF40B428AE976FB581E45F02619C61D2FE27AF6736B1449C06A17BFE20A967D4BA8625051D7E09C32AA3244C719C4ED5C166AA885F512C3F02840764C3B3ADDA61883BB5927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXry+e/iQNe8Zw== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4465E4806B976005D2A3CB73EB55D026B13BE399A2A6377AE13424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 4/5] feedback_daemon: generate report right before sending X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Feedback daemon used to generate report before waiting (for an hour by default) until it's time to send it. Better actualize the reports and generate them right when it's time to send them. Part of #5750 --- src/box/lua/feedback_daemon.lua | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 43bbc1fa2..93bbb2a11 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -333,12 +333,13 @@ local function feedback_loop(self) fiber.name(PREFIX, { truncate = true }) while true do - local feedback = self:generate_feedback() local msg = self.control:get(self.interval) -- if msg == "send" then we simply send feedback if msg == "stop" then break - elseif feedback ~= nil then + end + local feedback = self:generate_feedback() + if feedback ~= nil then if is_first_send then fiber.sleep(10) is_first_send = nil -- 2.24.3 (Apple Git-128)