From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 335B223C89
	for <tarantool-patches@freelists.org>; Wed, 27 Jun 2018 14:04:43 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id sEAIZOzrMJpd for <tarantool-patches@freelists.org>;
	Wed, 27 Jun 2018 14:04:43 -0400 (EDT)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E0E5322B92
	for <tarantool-patches@freelists.org>; Wed, 27 Jun 2018 14:04:42 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v4 6/8] sql: refactor AST trigger
 object name
References: <cover.1530029141.git.kshcherbatov@tarantool.org>
 <81986d1f9307191bd3d3e37514dc32fadb7e6970.1530029141.git.kshcherbatov@tarantool.org>
 <A0837193-E16E-4083-95C8-D3FFCF9EC2E7@tarantool.org>
 <3563ea71-30c6-3f20-8484-7970786c3de6@tarantool.org>
 <AEFCD088-54C0-47BC-AD9A-68EE69BD2DE9@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <ed452fdb-caf5-0a34-b6e5-a548d9a94e37@tarantool.org>
Date: Wed, 27 Jun 2018 21:04:40 +0300
MIME-Version: 1.0
In-Reply-To: <AEFCD088-54C0-47BC-AD9A-68EE69BD2DE9@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>

> I mean not all of these variables are initialised. For example, you can move
-       /* Name of trigger. */
-       char *trigger_name;
        /* SQL text. */
        char *sql_str = NULL;
        /* MsgPack containing SQL options. */
@@ -190,7 +188,7 @@ sql_trigger_finish(struct Parse *parse, struct TriggerStep *step_list,
        parse->parsed_ast.trigger = NULL;
        if (NEVER(parse->nErr) || trigger == NULL)
                goto triggerfinish_cleanup;
-       trigger_name = trigger->zName;
+       char *trigger_name = trigger->zName;

Ok, as you wish.