From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1900C29E06 for ; Thu, 18 Apr 2019 07:39:15 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bhIFX62yTHHf for ; Thu, 18 Apr 2019 07:39:15 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CA2031FC3C for ; Thu, 18 Apr 2019 07:39:14 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine References: <265af30c-727f-e781-e2c3-4bc13c98eeae@tarantool.org> <20190417081320.xwcf3ogkvrspgdu3@tarantool.org> <68ec9d10-4fa6-4997-54bd-4a80b1ca79ce@tarantool.org> <20190418081630.yfe5hi7w2m3bu5lh@tarantool.org> <77d5c2c1-8a26-990c-0fc0-dc40d56f64ae@tarantool.org> <20190418111411.hl4okehi6adv6pvi@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 18 Apr 2019 14:39:12 +0300 MIME-Version: 1.0 In-Reply-To: <20190418111411.hl4okehi6adv6pvi@tarantool.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Yukhin Cc: tarantool-patches@freelists.org On 18/04/2019 14:14, Kirill Yukhin wrote: > Hello, > > On 18 апр 13:43, Vladislav Shpilevoy wrote: >> Hi! Thanks for the fixes! See 4 comments below. >> >> 1. Now I see that sysview tuple format leaks. Please, >> apply this diff: >> >> ====================================================== >> diff --git a/src/box/sysview.c b/src/box/sysview.c >> index 0b07c9f4a..96c5e78ca 100644 >> --- a/src/box/sysview.c >> +++ b/src/box/sysview.c >> @@ -545,6 +545,8 @@ sysview_engine_create_space(struct engine *engine, struct space_def *def, >> free(space); >> return NULL; >> } >> + /* Format is now referenced by the space. */ >> + tuple_format_unref(format); >> return space; >> } >> ====================================================== > > Done. > > Branch force-pushed and re-tested. How was it retested? [024] Test failed! Result content mismatch: [024] --- wal_off/alter.result Thu Apr 18 14:36:14 2019 [024] +++ wal_off/alter.reject Thu Apr 18 14:37:03 2019 [024] @@ -28,7 +28,7 @@ [024] ... [024] #spaces; [024] --- [024] -- 65488 [024] +- 65505 [024] ... [024] -- cleanup [024] for k, v in pairs(spaces) do [024] Looks like some of the previously leaking formats are back in the pool, good. > > -- > Regards, Kirill Yukhin >