From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kshcherbatov@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v5 04/12] box: introduce
 tuple_format_add_key_part
References: <cover.1540795996.git.kshcherbatov@tarantool.org>
 <117feb46f029d4ba5d142fc614e063e2796a4f38.1540795996.git.kshcherbatov@tarantool.org>
 <20181101143841.GF30032@chai>
Message-ID: <ed297cd4-dce1-f7e1-ad5b-90ff72b7971c@tarantool.org>
Date: Tue, 6 Nov 2018 15:15:02 +0300
MIME-Version: 1.0
In-Reply-To: <20181101143841.GF30032@chai>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: tarantool-patches@freelists.org, Kostya Osipov <kostja@tarantool.org>, Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

> The patch is OK to push but I object to the name.
> 
> A format doesn't contain key parts. A key def contains key part. A
> format is consistent with key parts. 
> 
> tuple_format_update_with_key_part() perhaps?
> tuple_format_combine_with_key_part()?
> tuple_format_mix_in_key_part()?
> tuple_format_use_key_part()?

Ok, I'd like to use tuple_format_use_key_part routine name.