From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 662CF6C1AE; Fri, 21 May 2021 22:30:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 662CF6C1AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621625438; bh=EucuHZy5GFTDX37K/pk9zJK1Y979nBnKWvPa8A2wHA0=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vnTEvZh45jshkCQjb/oDvbrcQu8Y2UUIHHO+orRvssaE0sPPAIlgaFBhQBMG4bREc Wu/N3MqJs9BqTEzzktI5sD6LePms3HRb5QIHIBQWmyIYmWrkqiiACOKaaDywyggUEu ZrbhvHJ/i8xuFjmjf3PxAT2du3SNxnKO88Vn1fsA= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7BB946C1AE for ; Fri, 21 May 2021 22:30:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7BB946C1AE Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lkAqx-0002vG-OB; Fri, 21 May 2021 22:30:36 +0300 To: Yaroslav Dynnikov References: <04d7d05f09a5ee7ed52b27c480e81232c406e415.1620903962.git.v.shpilevoy@tarantool.org> Message-ID: Date: Fri, 21 May 2021 21:30:34 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AF6F63A46F26EE68FD6CF19A7203B0589400894C459B0CD1B975C66BBA105349DC64FA466D2F6491B466ABEBE91DA44D54CE4EC1BF0D3C05BC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE706EA9E10470DC775EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374ECA27954A00B6C3EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D4047E6EF147DB75656310B3DDE2F3F3132FCC7F00164DA146DAFE8445B8C89999728AA50765F79006377C70927E34808485389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC84B3849D6E5CCBAFD117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A599D953B34F4B5F646A2B4B0C079DB2111CA5294071D3BA3BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C0DDD40374D35017D094E96F0264CD81F825A003908FCD21E0374EFF30CC8566690717750E4B08921D7E09C32AA3244C86EE8FA86AE166B064B695F533CD2A7E795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3CIvDNz8QqBf8a5AIXzS2Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822C7296797C1DC52B9DC108DB53C16BC083841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2] vshard: fix buckets_count() on replicas X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! > diff --git a/test/misc/reconfigure.result b/test/misc/reconfigure.result > index 3b34841..a03ab5a 100644 > --- a/test/misc/reconfigure.result > +++ b/test/misc/reconfigure.result > @@ -271,9 +271,9 @@ box.cfg.read_only >  --- >  - false >  ... > -#box.space._bucket:on_replace() > +assert(#box.space._bucket:on_replace() == 1) >  --- > -- 1 > +- true >  ... > > > Why is this change necessary? Seems now you miss an actual value in case the test fails. > This question applies to many cases below. See me response in the first email about the assertions. > No matter what testing framework is used, I think that > > assert_equals(value, 1) -- assertion failed: expected 1, got 2 > > is better (more helpful) than eager > > assert(value == 1) -- assertion failed Yes, but what you are describing is present in the tap tests framework. Which currently is hardly usable for complex multi-instance tests. Hence I use what is available. Decided not to implement my own testing suite for these checks as it is anyway trivial to get more info if they start failing. Until tap would be easier to use for multi-instance tests. > @@ -2612,17 +2676,15 @@ local function storage_cfg(cfg, this_replica_uuid, is_reload) >      local uri = luri.parse(this_replica.uri) >      schema_upgrade(is_master, uri.login, uri.password) > > -    if M.bucket_on_replace then > -        box.space._bucket:on_replace(nil, M.bucket_on_replace) > -        M.bucket_on_replace = nil > -    end > -    lref.cfg() > -    if is_master then > -        box.space._bucket:on_replace(bucket_generation_increment) > -        M.bucket_on_replace = bucket_generation_increment > +    if is_master or box.space._bucket then > +        schema_install_triggers() > > > +1 to Oleg, isn't _bucket check enough? I want to emphasize that on the master the bootstrap is finished anyway, because it performs the bootstrap. On the master no need to check for _bucket nor wait for the schema anyhow.