From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F04277030F; Thu, 25 Feb 2021 01:39:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F04277030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614206395; bh=nQU6geiur93MkVXNgHZW0zL8zEl6H8I8gvDSFAcVLyY=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NBQ/l7bXZZs1FQPIWaJVnLln/R0XBL2z0cUNapexT3iLF8DiDHlrXy0sicZHuxSQy chNfPQ2bJPFlwB/J84M/AY7TGVhkNVw8DFk2yhPZHdUgmyqyFN/TIlCVtJ32GFHHYP 8V7/Sg5ueFpuiv0oU0oS56XoJIpYPpBeuHOCVC4E= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 63EE57030F for ; Thu, 25 Feb 2021 01:39:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 63EE57030F Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1lF2ol-0008LL-UG; Thu, 25 Feb 2021 01:39:40 +0300 To: Cyrill Gorcunov , tml References: <20210222182030.76232-1-gorcunov@gmail.com> <20210224153626.121506-1-gorcunov@gmail.com> <20210224153626.121506-3-gorcunov@gmail.com> Message-ID: Date: Wed, 24 Feb 2021 23:39:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224153626.121506-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F566922928A658C60196E87DF7449A63D990329182A05F538085040CC018C1F97B6D43DCFD0CC3F834617621E1DB6201BA00007E51A3EBD890AA69A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7444CB0504BAF4550EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375A514678F9DF65078638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCEF6CC647C0669FAFD5B096D1E37EA8F7A38D0750836C6EEC389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249E534D5F67D1EC79B76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B9E732322B07FA9F33AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7B2B7C64F398C741067F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3E2C51E5CF308F7B035872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9AE7E30DF62CE24E4E5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A508000237F49FA3083BC632136A19BE986B07673C23030F35D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75968C9853642EB7C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A5112A9AECFE11B164A8C033C04E17CBCF95ECB61B4CAC84CEB37F35753EAB0FAB14849A305D3AA41D7E09C32AA3244C75860577CCDDEF20D4725282C1F5171530363D8B7DA7DD44729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj8hKOA2aG7fLQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA311046BF50748817AA4D1429D5F908B7F273FAC6A8E90AA9290407784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 02/10] popen: fix say_x format arguments X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! On 24.02.2021 16:36, Cyrill Gorcunov wrote: > Drop redundant "%s" from format. Neither of the changes below are about dropping a redundant %s. First one drops %p, second one replaces it with %d and fixes size_t. > Part-of #5846 > > Signed-off-by: Cyrill Gorcunov > --- > src/lib/core/popen.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c > index 3b5fd1062..99a3d3cbd 100644 > --- a/src/lib/core/popen.c > +++ b/src/lib/core/popen.c > @@ -240,7 +240,7 @@ handle_new(struct popen_opts *opts) > static inline void > handle_free(struct popen_handle *handle) > { > - say_debug("popen: handle %p free %p", handle); > + say_debug("popen: handle free %p", handle); > free(handle); > } > > @@ -533,7 +533,7 @@ popen_shutdown(struct popen_handle *handle, unsigned int flags) > if (handle->ios[idx].fd < 0) > continue; > > - say_debug("popen: %d: shutdown idx [%s:%d] fd %s", > + say_debug("popen: %d: shutdown idx [%s:%zd] fd %d", > handle->pid, stdX_str(idx), idx, > handle->ios[idx].fd); > coio_close_io(loop(), &handle->ios[idx]); >