From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D7E2742EF5D
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 21 Jun 2020 19:25:06 +0300 (MSK)
References: <cover.1592589312.git.sergepetrenko@tarantool.org>
 <46ed0cc08e6ecf7ee7c9250d9cdfc3d68aa5c764.1592589312.git.sergepetrenko@tarantool.org>
 <30f75001-3ecc-9d7f-9cba-88c824087f4e@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ecb9c03f-0977-7395-c7c5-8780e95ec7db@tarantool.org>
Date: Sun, 21 Jun 2020 18:25:05 +0200
MIME-Version: 1.0
In-Reply-To: <30f75001-3ecc-9d7f-9cba-88c824087f4e@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to
	use async txn_commit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, sergos@tarantool.org, gorcunov@tarantool.org, lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

> diff --git a/src/box/box.cc b/src/box/box.cc
> index f80d6f8e6..0fe7625fb 100644
> --- a/src/box/box.cc
> +++ b/src/box/box.cc
> @@ -222,6 +222,12 @@ box_process_rw(struct request *request, struct space *space,
>                  */
>                 if (is_local_recovery) {
>                         res = txn_commit_async(txn);
> +                       /*
> +                        * Hack: remove the unnecessary trigger.
> +                        * I don't know of a better place to do
> +                        * it.
> +                        */

Why is it necessary to remove it?

> + trigger_clear(&txn->on_write_failure);
>                 } else {
>                         res = txn_commit(txn);
>                 }