From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F9E6445320 for ; Tue, 28 Jul 2020 11:23:39 +0300 (MSK) References: <20200716182032.84609-1-olegrok@tarantool.org> From: Leonid Vasiliev Message-ID: Date: Tue, 28 Jul 2020 11:23:38 +0300 MIME-Version: 1.0 In-Reply-To: <20200716182032.84609-1-olegrok@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] lua: introduce function to check that passed value is uuid List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: olegrok@tarantool.org, v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Hi! Thank you for the patch. LGTM. Up to you: > We've already have is_decimal function that checks allowed value If I'm not mistaken: "We already have". I think the first sentence is unnecessary. > is decimal. After tarantool started to support UUID type it will > be quite often case to check that some value has UUID type as > well. This patch introduces "is_uuid" function for this purpose. > > Closes #5171 > > @TarantoolBot document > Title: uuid.is_uuid > > is_uuid function returns "true" if specified value has uuid type > and "false" otherwise.