From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 99802445322
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 12 Jul 2020 18:37:37 +0300 (MSK)
References: <cover.1591259297.git.sergeyb@tarantool.org>
 <c5f236c93b251b6a19eeb16c20a31adfc4f95b3e.1591259297.git.sergeyb@tarantool.org>
 <7b82ce9d-9840-f98a-6d99-38afdeac68d9@tarantool.org>
 <20200710165535.GA80670@pony.bronevichok.ru>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ebefc49c-ab5e-1758-d510-260e6c8798f3@tarantool.org>
Date: Sun, 12 Jul 2020 17:37:35 +0200
MIME-Version: 1.0
In-Reply-To: <20200710165535.GA80670@pony.bronevichok.ru>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 5/6] Fix luacheck warnings in
	src/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org

On 10.07.2020 18:55, Sergey Bronnikov wrote:
> On 18:28 Sun 05 Jul , Vladislav Shpilevoy wrote:
>>> diff --git a/src/lua/msgpackffi.lua b/src/lua/msgpackffi.lua
>>> index f01ffaef0..cb7ad5b88 100644
>>> --- a/src/lua/msgpackffi.lua
>>> +++ b/src/lua/msgpackffi.lua
>>> @@ -603,7 +599,7 @@ local function check_offset(offset, len)
>>>      if offset == nil then
>>>          return 1
>>>      end
>>> -    local offset = ffi.cast('ptrdiff_t', offset)
>>> +    offset = ffi.cast('ptrdiff_t', offset)
>>
>> Unnecessary diff.
> 
> Reverted in a branch.
> 
>>>      if offset < 1 or offset > len then
>>>          error(string.format("offset = %d is out of bounds [1..%d]",
>>>              tonumber(offset), len))

Looks like it is not. I still see it on the branch.
https://github.com/tarantool/tarantool/blob/ligurio/gh-4681-fix-luacheck-warnings-src/src/lua/msgpackffi.lua#L602