From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A6B95C99148; Thu, 15 Aug 2024 16:19:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A6B95C99148 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1723727963; bh=D3d2xjkd/AoeoyUxEZ1Z9hKWdRpK2vW7NH0jIcg/kGY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=RiuRjnLOSo+hqvDPqtwUzssrirDDo0RiFPeuhD2wXZxdnlMNu+tz3Ye4RGdkxDufJ DbdWJjtkKJ2bfjL1+bJRfXiFU5WXzVihruMKI940hMjMBPsSiiETLjzgPGt6qimK7/ 25jRG14rJ1PuQXfXTLojpBE68elxvYJ7Xn1R/YS4= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [95.163.41.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3289AC99157 for ; Thu, 15 Aug 2024 16:19:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3289AC99157 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1seaNt-0000000AQhV-0NR9; Thu, 15 Aug 2024 16:19:21 +0300 Content-Type: multipart/alternative; boundary="------------DKwtUJ0EWy2YB7H00M5Nm8Ag" Message-ID: Date: Thu, 15 Aug 2024 16:19:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <0b86cd86732162470eea910ae9cdea48219e53bd.1723638851.git.skaplun@tarantool.org> <52343605-6c27-4f5e-8cef-7a350d378261@tarantool.org> In-Reply-To: <52343605-6c27-4f5e-8cef-7a350d378261@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9F97E3C14763C38E2E053F12B874BEA7ABF7E130D634E7BB8182A05F538085040FC9A6B49C9D52BC8C591814E25D11F9FAFE65E113AC6662C0D0D019245ED27CD5F4536BA978BAB39 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE731B6267C8418DDA1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770398A047C76876C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89E92CE2DDAE057A17393CF6A45A21CAA70F40029E8A5A753CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063790495A4AD0498982D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE72B056A9979167638EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3F6A27782D052760535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5C43383697E566D7E5002B1117B3ED6960C77D926093DC317559C6C5561145D6F823CB91A9FED034534781492E4B8EEAD17AEC49845D0B908 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF9F3047C0B2F03853D2E80CCE4538A2FB147FDC4870DD25AE8570D2C63A4EDF9FF93E7F6CC6F26229470327EB0AC8E6932E121E87C741E6E7413BDEADF122B97349AA03710F1B789C5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojD5rM0r3KxnGwLipA39lq1g== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614096C4F356863EA981338864B06A7D583B91667830A504A97B0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 06/36] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------DKwtUJ0EWy2YB7H00M5Nm8Ag Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit dualnum is an optional LuaJIT feature (LJ_DUALNUM), why we don't have a separate flag for the test that will disable test when feature is not available? On 15.08.2024 16:11, Sergey Bronnikov via Tarantool-patches wrote: > > Hi, Sergey > > thanks for the patch! > > see my comments below > > On 14.08.2024 16:55, Sergey Kaplun wrote: >> This patch moves the aforementioned test from the to the >> directory, includes it in , and names subtests. > > Add a reason for this and couple of words about updated formatting in > the test. > > >> Part of tarantool/tarantool#9398 >> --- >> test/LuaJIT-tests/{misc => lang}/dualnum.lua | 24 +++++++++----------- >> test/LuaJIT-tests/lang/index | 1 + >> 2 files changed, 12 insertions(+), 13 deletions(-) >> rename test/LuaJIT-tests/{misc => lang}/dualnum.lua (57%) >> >> diff --git a/test/LuaJIT-tests/misc/dualnum.lua b/test/LuaJIT-tests/lang/dualnum.lua >> similarity index 57% >> rename from test/LuaJIT-tests/misc/dualnum.lua >> rename to test/LuaJIT-tests/lang/dualnum.lua >> index 5f1288c8..688920eb 100644 >> --- a/test/LuaJIT-tests/misc/dualnum.lua >> +++ b/test/LuaJIT-tests/lang/dualnum.lua >> @@ -1,34 +1,32 @@ >> +-- Test LuaJIT Dualnum mode behaviour. >> >> --- Positive overflow >> -do >> +do --- Positive overflow. >> local x = 0 >> - for i=2147483446,2147483647,2 do x = x + 1 end >> + for _ = 2147483446, 2147483647, 2 do x = x + 1 end >> assert(x == 101) >> end >> >> --- Negative overflow >> -do >> +do --- Negative overflow. >> local x = 0 >> - for i=-2147483447,-2147483648,-2 do x = x + 1 end >> + for _ = -2147483447, -2147483648, -2 do x = x + 1 end >> assert(x == 101) >> end >> >> --- SLOAD with number to integer conversion. >> -do >> +do --- SLOAD with number to integer conversion. >> local k = 1 >> local a, b, c = 1/k, 20/k, 1/k >> - for i=1,20 do >> - for j=a,b,c do end >> + for i = 1, 20 do >> + for j = a, b, c do end >> end >> end >> >> -do >> +do --- min/max correctness. >> local function fmin(a, b) >> - for i=1,100 do a = math.min(a, b) end >> + for _ = 1, 100 do a = math.min(a, b) end >> return a >> end >> local function fmax(a, b) >> - for i=1,100 do a = math.max(a, b) end >> + for _ = 1, 100 do a = math.max(a, b) end >> return a >> end >> assert(fmin(1, 3) == 1) >> diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index >> index 4d9feafd..b0e7f073 100644 >> --- a/test/LuaJIT-tests/lang/index >> +++ b/test/LuaJIT-tests/lang/index >> @@ -6,6 +6,7 @@ catch_wrap.lua >> compare.lua >> compare_nan.lua >> constant >> +dualnum.lua >> for.lua >> length.lua >> lightud.lua --------------DKwtUJ0EWy2YB7H00M5Nm8Ag Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

dualnum is an optional LuaJIT feature (LJ_DUALNUM), why we don't have a separate flag for

the test that will disable test when feature is not available?



On 15.08.2024 16:11, Sergey Bronnikov via Tarantool-patches wrote:

Hi, Sergey

thanks for the patch!

see my comments below

On 14.08.2024 16:55, Sergey Kaplun wrote:
This patch moves the aforementioned test from the <misc> to the <lang/>
directory, includes it in <index>, and names subtests.

Add a reason for this and couple of words about updated formatting in the test.


Part of tarantool/tarantool#9398
---
 test/LuaJIT-tests/{misc => lang}/dualnum.lua | 24 +++++++++-----------
 test/LuaJIT-tests/lang/index                 |  1 +
 2 files changed, 12 insertions(+), 13 deletions(-)
 rename test/LuaJIT-tests/{misc => lang}/dualnum.lua (57%)

diff --git a/test/LuaJIT-tests/misc/dualnum.lua b/test/LuaJIT-tests/lang/dualnum.lua
similarity index 57%
rename from test/LuaJIT-tests/misc/dualnum.lua
rename to test/LuaJIT-tests/lang/dualnum.lua
index 5f1288c8..688920eb 100644
--- a/test/LuaJIT-tests/misc/dualnum.lua
+++ b/test/LuaJIT-tests/lang/dualnum.lua
@@ -1,34 +1,32 @@
+-- Test LuaJIT Dualnum mode behaviour.
 
--- Positive overflow
-do
+do --- Positive overflow.
   local x = 0
-  for i=2147483446,2147483647,2 do x = x + 1 end
+  for _ = 2147483446, 2147483647, 2 do x = x + 1 end
   assert(x == 101)
 end
 
--- Negative overflow
-do
+do --- Negative overflow.
   local x = 0
-  for i=-2147483447,-2147483648,-2 do x = x + 1 end
+  for _ = -2147483447, -2147483648, -2 do x = x + 1 end
   assert(x == 101)
 end
 
--- SLOAD with number to integer conversion.
-do
+do --- SLOAD with number to integer conversion.
   local k = 1
   local a, b, c = 1/k, 20/k, 1/k
-  for i=1,20 do
-    for j=a,b,c do end
+  for i = 1, 20 do
+    for j = a, b, c do end
   end
 end
 
-do
+do --- min/max correctness.
   local function fmin(a, b)
-    for i=1,100 do a = math.min(a, b) end
+    for _ = 1, 100 do a = math.min(a, b) end
     return a
   end
   local function fmax(a, b)
-    for i=1,100 do a = math.max(a, b) end
+    for _ = 1, 100 do a = math.max(a, b) end
     return a
   end
   assert(fmin(1, 3) == 1)
diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index
index 4d9feafd..b0e7f073 100644
--- a/test/LuaJIT-tests/lang/index
+++ b/test/LuaJIT-tests/lang/index
@@ -6,6 +6,7 @@ catch_wrap.lua
 compare.lua
 compare_nan.lua
 constant
+dualnum.lua
 for.lua
 length.lua
 lightud.lua
--------------DKwtUJ0EWy2YB7H00M5Nm8Ag--