From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3AB3D22139 for ; Mon, 2 Jul 2018 09:50:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s-K9WiyAMS0a for ; Mon, 2 Jul 2018 09:50:50 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E0FEA209B6 for ; Mon, 2 Jul 2018 09:50:49 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] sql: remove support of partial indexes from parser References: <20180702110824.28899-1-korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Mon, 2 Jul 2018 16:50:44 +0300 MIME-Version: 1.0 In-Reply-To: <20180702110824.28899-1-korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Nikita Pettik , tarantool-patches@freelists.org Cc: Gleb Hello. Thanks for the patch! See 1 comment below. On 02/07/2018 14:08, Nikita Pettik wrote: > From: Gleb > > Currently, Tarantool doesn't support partial indexes, so lets temporary > remove their processing from SQL parser to avoid confusing situations. > It can be returned after #1260 (implement functional indexes in > Tarantool) is done. > > Closes #2165 > --- > Branch: https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes > Issue: https://github.com/tarantool/tarantool/issues/2165 > > src/box/sql/parse.y | 4 ++-- > test/sql-tap/analyze9.test.lua | 2 +- > test/sql-tap/autoindex4.test.lua | 2 +- > test/sql-tap/fkey1.test.lua | 2 +- > test/sql-tap/index6.test.lua | 12 ++++++------ > test/sql-tap/index7.test.lua | 14 ++++++++------ > 6 files changed, 19 insertions(+), 17 deletions(-) > > diff --git a/test/sql-tap/index7.test.lua b/test/sql-tap/index7.test.lua > index c8f56eb29..11728d39e 100755 > --- a/test/sql-tap/index7.test.lua > +++ b/test/sql-tap/index7.test.lua > @@ -291,14 +291,16 @@ test:do_eqp_test( > -- > }) > > +-- gh-2165 Currently, Tarantool lacks support of partial indexes, > +-- so temporary we removed processing of their syntax from parser. > +-- > test:do_catchsql_test( > - "index7-6.5", > + "index7-7.1", > [[ > - CREATE INDEX t5a ON t5(a) WHERE a=#1; > + CREATE TABLE t1 (a INTEGER PRIMARY KEY, b INTEGER) > + CREATE UNIQUE INDEX i ON t1 (a) WHERE a = 3; > ]], { > - -- > - 1, [[near "#1": syntax error]] > - -- > + 1, "keyword \"CREATE\" is reserved" 1. The error is caused by typo in the request, not by lack of partial indexes. > }) > > test:finish_test() > The rest is ok if the single purpose of the patch is to remove partial indexes from frontend.