From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 74DE07030F; Thu, 25 Feb 2021 01:43:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 74DE07030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614206635; bh=8Rk5cKJnxFf+lX6dAzPYgu52h4hQ/998katwdTBdhuo=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JfJ504k5LAQAtl/l7hzVZ+x0S6eM1734anoebSmkGncgWTwpyl7oTSpYo+rfoTBIN kCyQtE4mbAbKAT24ZbBKjDrwcnliGEz1Y1mY8s7sQbAQcNrsfYDkeyK7/fqgnAPVbj ejmBwWmOdPaW4wnCYdu2nmu3ZkQx0fCJ+BBGhiCs= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3633A7030F for ; Thu, 25 Feb 2021 01:43:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3633A7030F Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1lF2sr-0001Fn-Cb; Thu, 25 Feb 2021 01:43:53 +0300 To: Cyrill Gorcunov , tml , "n.pettik" References: <20210222182030.76232-1-gorcunov@gmail.com> <20210224153626.121506-1-gorcunov@gmail.com> <20210224153626.121506-7-gorcunov@gmail.com> Message-ID: Date: Wed, 24 Feb 2021 23:43:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224153626.121506-7-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F5669229511437AA01F46811CFCF616A939B362182A05F53808504056A19B241FBA465496752F9A555F5AB9785FE74DCF0AA38519E030C694B5206D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79B4AFF82F0254274EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374ECA27954A00B6C3EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C614F7D797F0332DCA5CD26502F09EEF9153E22996315E92B9FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B974A882099E279BDA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC4F11CE3B8CFE7BE63AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F7900637279A72B19F76E6D3D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CB24F08513AFFAC7993EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B610E4EE32A3E37749089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7025EC15B47EAE72BACBD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5B213B6F511BBE619D318A7186E8CE0B63AD65418D7647769D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75968C9853642EB7C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341B5517184E88C1BD224E30467137479820DA08432A1CA9F88735DDEA6488AA5C75D0347AE402D09A1D7E09C32AA3244CA918FC2F1C605ED39330359D313DDAD85A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj+lwbQ3xhD0SA== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110168A442D491C890B56A0C03973572225A3FD40067C640BF307784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 06/10] box/vynil: fix say_x format X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! This bug could actually lead to a crash. Because the printer would try to read memory by a not passed string pointer. Nikita, does it look related to any of the crashes we have in vinyl? On 24.02.2021 16:36, Cyrill Gorcunov wrote: > Drop redundant "%s" from format. > > Part-of #5846 > > Signed-off-by: Cyrill Gorcunov > --- > src/box/vy_scheduler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/box/vy_scheduler.c b/src/box/vy_scheduler.c > index b641dd9b8..6f6e9c340 100644 > --- a/src/box/vy_scheduler.c > +++ b/src/box/vy_scheduler.c > @@ -1714,7 +1714,7 @@ vy_task_compaction_new(struct vy_scheduler *scheduler, struct vy_worker *worker, > vy_task_delete(task); > err_task: > diag_log(); > - say_error("%s: could not start compacting range %s: %s", > + say_error("%s: could not start compacting range %s", > vy_lsm_name(lsm), vy_range_str(range)); > return -1; > } >