From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AD3675818DF; Wed, 16 Aug 2023 20:15:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AD3675818DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692206134; bh=eRDZh7dfR9bb9K696rr1jAEv7bsGwyNp79+PQT1pFsc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZlJo1lcf09fjTVBplIVCtUz/RLa8S+BopSDPpRMxlTC1JoYPlEvLM3AfhroWdCQEQ 6OyK4Gk0AGKBTIibJ0A7EMg21O6k9DQrVsKGMOw/Mh/67GKN/mIt11Njv6bbO6gVDV chxbgQDhfBg/W8SU05fysTSuIHNxUIJXuw6B+OIA= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C2A8D58123F for ; Wed, 16 Aug 2023 20:15:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C2A8D58123F Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1qWK7I-00H9wu-1Q; Wed, 16 Aug 2023 20:15:32 +0300 Message-ID: Date: Wed, 16 Aug 2023 20:15:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin References: <8bd95083805e240d65b2c02524ffb3ad8d91b414.1691592488.git.skaplun@tarantool.org> In-Reply-To: <8bd95083805e240d65b2c02524ffb3ad8d91b414.1691592488.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D12A1D0741C7E82ED7F70A80435AA08BE182A05F538085040F110A074E16376FE0D0832C8E50B34CC75EEA14847D3F3CDCFE57EC15DA3A9CD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E347E1311495C1B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B6B600A8E3984DD1BA471F72B93EF1AA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC0F49EF363AAD6E82A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE26055571C92BF10F302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3A367EA73E0D98AAD76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249D082881546D93491E827F84554CEF50127C277FBC8AE2E8B03FB6F9198DE190422CA9DD8327EE4930A3850AC1BE2E7356D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5351B6221F3506DFD7F4336431623282AE1025A028F061139F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFD45B330E5680C54E99AFFCFF57E6D762AF0AEBD8B8A313DDB341DAFE213711D645D21F2230575A0F24F7434E9608BF9FEC4BB4603E3BC2E39F4306B9BC89301DA74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxr5fPz28rxYnQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458CE820F31FED02DA95998C10E7BA3639A2E10D788B03576C6282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 10/19] Cleanup math function compilation and fix inconsistencies. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM On 8/9/23 18:35, Sergey Kaplun wrote: > From: Mike Pall > > (cherry picked from commit 5655be4546d9177890c69f0d0accac4773ff0887) > > This patch backports the aforementioned patch for mips and ppc, because > those architectures were stripped during the backporting via > 71ec8eb232d4dfa8df2cbbae65b799b2ce493979 ("Cleanup math function > compilation and fix inconsistencies."). This applies these missed diffs > to prevent conflict during backporting future patches. > > This patch just removes macros, that are no more in use. > > Sergey Kaplun: > * added the description for the problem > > Part of tarantool/tarantool#8825 > --- > src/lj_asm_mips.h | 1 - > src/lj_asm_ppc.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/lj_asm_mips.h b/src/lj_asm_mips.h > index a26a82cd..c27d8413 100644 > --- a/src/lj_asm_mips.h > +++ b/src/lj_asm_mips.h > @@ -1794,7 +1794,6 @@ static void asm_abs(ASMState *as, IRIns *ir) > } > #endif > > -#define asm_atan2(as, ir) asm_callid(as, ir, IRCALL_atan2) > #define asm_ldexp(as, ir) asm_callid(as, ir, IRCALL_ldexp) > > static void asm_arithov(ASMState *as, IRIns *ir) > diff --git a/src/lj_asm_ppc.h b/src/lj_asm_ppc.h > index 6cb608f7..6aaed058 100644 > --- a/src/lj_asm_ppc.h > +++ b/src/lj_asm_ppc.h > @@ -1390,7 +1390,6 @@ static void asm_neg(ASMState *as, IRIns *ir) > } > > #define asm_abs(as, ir) asm_fpunary(as, ir, PPCI_FABS) > -#define asm_atan2(as, ir) asm_callid(as, ir, IRCALL_atan2) > #define asm_ldexp(as, ir) asm_callid(as, ir, IRCALL_ldexp) > > static void asm_arithov(ASMState *as, IRIns *ir, PPCIns pi)