From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Kirill Shcherbatov Subject: [PATCH v1 1/1] box: fix crash in ncurses on fedora 28 Date: Wed, 8 Aug 2018 16:52:28 +0300 Message-Id: To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: Tarantool has been crashing when trying to go into an interactive loop in ncurses-libs/libtinfo library via lbox_console_readline. This SIGABORT caused by stack probing code that present in new ncurses distributions. lea r11,[rsp-frameSize] label: sub rsp,pageSize or QWORD PTR [rsp],0x0 cmp rsp,r11 jne label Where frameSize is 0x8000 and pageSize is 0x1000 for version we've dedugged. Code above tests marker value on pages start. 0x8000 frameSize is a precompiled ncurse's binary internal value. This third-party library is called by tarantool fiber that have fiber stack of size 2*0x8000. To the moment of crash, stack memory distributed: ncurses stack usage 0x91A8 bytes total stack usage 0x9488 bytes We have to increase interactive console main loop fiber stack to work with third-party libraries normally. Closes #3418. --- Branch: https://github.com/tarantool/tarantool/tree/kshch/gh-3418-crash-on-fedora Issue: https://github.com/tarantool/tarantool/issues/3418 src/lua/init.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lua/init.c b/src/lua/init.c index a0a7f63..217640f 100644 --- a/src/lua/init.c +++ b/src/lua/init.c @@ -610,8 +610,10 @@ tarantool_lua_run_script(char *path, bool interactive, * To work this problem around we must run init script in * a separate fiber. */ - - script_fiber = fiber_new(title, run_script_f); + struct fiber_attr fiber_attr = + {.stack_size = 0x8000 * 4, + .flags = FIBER_DEFAULT_FLAGS | FIBER_CUSTOM_STACK}; + script_fiber = fiber_new_ex(title, &fiber_attr, run_script_f); if (script_fiber == NULL) panic("%s", diag_last_error(diag_get())->errmsg); fiber_start(script_fiber, tarantool_L, path, interactive, -- 2.7.4