From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 18A15A1C3A6; Thu, 8 Feb 2024 17:12:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 18A15A1C3A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707401551; bh=nLWAoByYQhC3sekcT7MkxpJ+pawDDYXHkWdFe1hFaaY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OJNwogCz55hvKhNbnpHFoe9Rtfk+6rdVd2dePdZeeBQkSW4tQE0xBObt4yqWsoMG9 knxa9MVO1eKAQMh0qqE06Q86Z7WviBLSdLkxiuZWHISSdaDzoQ7QxALMCHpm4W7BNx y3fvCZDufp6huUQ56Hye4BCfwnxlN9VduxgHM0vE= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E6C0FA1C380 for ; Thu, 8 Feb 2024 17:12:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E6C0FA1C380 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1rY58f-00000002Owa-0L70; Thu, 08 Feb 2024 17:12:29 +0300 Message-ID: Date: Thu, 8 Feb 2024 17:12:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <0d003159c9a1811d98e30a863cc75c11bab658a3.1706104777.git.skaplun@tarantool.org> <38004fc1-a985-4cf5-98bd-d207360f753d@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD91FEFD63CE1B099166B8218180541CC8CDEC38F805112F7CC00894C459B0CD1B958F279AD0481C1C23554E6EA4911C96F269E48A6EEEF9D4E525730FEB34844D8AD222422030090D9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745476ED688D943148638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84DA21FA20D87D622A432491C821D7518BC91E18DC52270CFCC7F00164DA146DAFE8445B8C89999728AA50765F790063793270F7220657A0A389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AF9735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3F6FBD7DDCBC7A9A5BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C37727919777A35F2B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5C802AE3A06B8B6FC5002B1117B3ED6969B4EF57D6FAB449F4869453249F34FA4823CB91A9FED034534781492E4B8EEADA91A6E18C88C5E2F X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF86EED2CFFDBF5B8DEF7ABE5CB80BD2369E77D6D67D100F28F620E732DA59CE08A5CD7B9A90500322766A7423F6D95CBE9FAE085C9F20DEF18E78FC80918575EE9514C8EE737A1E645F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojt6itc0777ZomfxXY+nUp6Q== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845876C6B91A1A08D8E19B464708D7791FD7D3B0A63EC3982A912CA1F4C27F84AF43645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey (spoiler - LGTM) On 2/6/24 14:41, Sergey Kaplun wrote: > On 06.02.24, Sergey Bronnikov wrote: >> On 2/6/24 13:07, Sergey Kaplun wrote: >>> Hi, Sergey! >>> Thanks for the review! >>> >>> On 06.02.24, Sergey Bronnikov wrote: >>>> Hi, Sergey >>>> >>>> thanks for the patch! test is passed with reverted patch. > Do you revert only this patch or the previous one too (or run just on > the cloned master)? > Because without the previous patch (1/2), the repro doesn't work. > > I've tried this flags locally and test is failed as expeced for GC64 and > non-GC64 builds. > > Seems it was a problem on my side (probably forgot to stash patch after `git reset`). The problem is reproduced by test, luajit is crashed with segmentation fault. Patch LGTM, thanks!