From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 64931469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 19 May 2020 09:47:17 +0300 (MSK)
References: <20200512135052.221379-1-gorcunov@gmail.com>
 <20200512135052.221379-5-gorcunov@gmail.com>
 <6c634b97-e9bd-c2eb-0916-c303cd2ccadf@tarantool.org>
 <20200518211736.GF5455@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <eace485f-6a31-fb13-156b-bc3b6ebdaac0@tarantool.org>
Date: Tue, 19 May 2020 09:47:15 +0300
MIME-Version: 1.0
In-Reply-To: <20200518211736.GF5455@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 4/7] box/console: rename
 luaL_yaml_default to serializer_yaml
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

Igor, thanks for explanation! Yes, then my comment is not relevant.

On 19/05/2020 00:17, Igor Munkin wrote:
> Oleg,
> 
> On 18.05.20, Oleg Babin wrote:
>> Hi! I'm not sure that we really should do that. Functions with LuaL
>> prefix is a part of Lua code convention AFAIK.
>> (https://www.lua.org/manual/5.1/manual.html#4)
> 
> No, it doesn't relate to Lua code convention (at least to the one you've
> mentioned). luaL_ is just a custom prefix for functions declared/defined
> in lauxlib.h header, which is a part of Lua public API.
> 
> | All functions from the auxiliary library are defined in header file
> | lauxlib.h and have a prefix luaL_.
> 
> However this prefix is also used for auxiliary functions provided by
> Tarantool (e.g luaL_pushcdata). This *might* be an argument for
> convention saving but it's definitely a weak one for these changes. I
> see no problems with the renaming Cyrill made within this patch, since
> it just affects the name of the static global variable. Please also
> consider the issue[1] that closely relates to the subj.
> 
>>
> 
> <snipped>
> 
> [1]: https://github.com/tarantool/tarantool/issues/4577
>