From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C5E394696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  9 Apr 2020 10:30:53 +0300 (MSK)
References: <cover.1586341316.git.sergeyb@tarantool.org>
 <10d6c48a3f320e81b8bd8b05de385f20cbfead9c.1586341316.git.sergeyb@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <e9a28a7e-94af-c9b9-3735-b32f5aa8356e@tarantool.org>
Date: Thu, 9 Apr 2020 10:30:51 +0300
MIME-Version: 1.0
In-Reply-To: <10d6c48a3f320e81b8bd8b05de385f20cbfead9c.1586341316.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 4/6] Fix luacheck warnings in
 extra/dist/tarantoolctl.in
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <estetus@gmail.com>, tarantool-patches@dev.tarantool.org
Cc: o.piskunov@tarantool.org

Hi! Thanks for your patch! See my comment below.

On 08/04/2020 18:43, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> @@ -420,7 +419,7 @@ local cat_formats = setmetatable({
>       json = cat_json_cb,
>       lua  = cat_lua_cb,
>   }, {
> -    __index = function(self, cmd)
> +    __index = function(cmd)
>           error(("Unknown formatter '%s'"):format(cmd))
>       end
>   })

You can't simply drop "self" argument. See [1]. I assume that a change 
that doesn't break behaviour is "function(_, cmd)".


[1] https://www.lua.org/pil/13.4.1.html

---
Oleg Babin