From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5A146469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 15 Mar 2020 18:31:52 +0300 (MSK)
References: <cover.1583917262.git.k.sosnin@tarantool.org>
 <9547e0b11186786ebbc507536938f2764cb5fe58.1583917262.git.k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <e89bc03f-0e17-1225-2ff8-0ba1d61864f0@tarantool.org>
Date: Sun, 15 Mar 2020 16:31:50 +0100
MIME-Version: 1.0
In-Reply-To: <9547e0b11186786ebbc507536938f2764cb5fe58.1583917262.git.k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 2/2] iproto: add an empty body to
 the unprepare response
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

See 2 comments below.

> diff --git a/src/box/iproto.cc b/src/box/iproto.cc
> index f313af6ae..5a3fb5d0b 100644
> --- a/src/box/iproto.cc
> +++ b/src/box/iproto.cc
> @@ -1871,7 +1874,7 @@ net_send_msg(struct cmsg *m)
>  }
>  
>  /**
> - * Complete sending an iproto error: 
> + * Complete sending an iproto error:

1. Seems like a stray not related change.

>   * recycle the error object and flush output.
>   */
>  static void
> diff --git a/test/box/gh-4769-unprepare-response-body.result b/test/box/gh-4769-unprepare-response-body.result
> new file mode 100644
> index 000000000..a5230fad1
> --- /dev/null
> +++ b/test/box/gh-4769-unprepare-response-body.result
> @@ -0,0 +1,62 @@
> +-- test-run result file version 2
> +test_run = require('test_run').new()
> + | ---
> + | ...
> +test_run:cmd("setopt delimiter ';'")

2. Why? You never use the new delimiter until you
reset it back to normal.

You don't even need test_run = require('test_run').new(),
because without the needless delimiter change the
test_run object is also unused.

> + | ---
> + | - true
> + | ...
> +
> +net_box = require('net.box')
> +msgpack = require('msgpack')
> +urilib = require('uri')
> +
> +IPROTO_REQUEST_TYPE = 0x00
> +IPROTO_PREPARE      = 13
> +IPROTO_SQL_TEXT     = 0x40
> +IPROTO_STMT_ID      = 0x43
> +
> +test_run:cmd("setopt delimiter ''");
> + | ---
> + | ...
> +