From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2E8E02DDD2
	for <tarantool-patches@freelists.org>; Mon, 29 Oct 2018 17:32:55 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1VqdJFh5FQJG for <tarantool-patches@freelists.org>;
	Mon, 29 Oct 2018 17:32:55 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E106D2DDC2
	for <tarantool-patches@freelists.org>; Mon, 29 Oct 2018 17:32:54 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 4/6] sql: enforce implicit type
 conversions
References: <cover.1537216077.git.korablev@tarantool.org>
 <d060ef561a49722c55bff0ead926f9642df98e54.1537216078.git.korablev@tarantool.org>
 <3ba8b43c-c6d5-ff34-1fd2-c302eae1a760@tarantool.org>
 <98FC4C78-08BF-4B69-8F79-9562F1285432@tarantool.org>
 <999eb301-5c83-f1d8-491d-87c52ab5815f@tarantool.org>
 <E2586704-DF9B-4D7D-9E01-F1D20B8A6B6F@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <e74a3d99-7756-20d2-3909-e7a3ab73fc8b@tarantool.org>
Date: Tue, 30 Oct 2018 00:32:52 +0300
MIME-Version: 1.0
In-Reply-To: <E2586704-DF9B-4D7D-9E01-F1D20B8A6B6F@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org

Thanks for the fixes! See 3 comments below.

> --- a/test/sql-tap/boundary1.test.lua
> +++ b/test/sql-tap/boundary1.test.lua
> @@ -7649,5 +7649,4 @@ test:do_execsql_test(
>      "boundary1-2.66.le.5",
>      "SELECT a FROM t1 WHERE rowid <= -9.22337303685477580800e+18 ORDER BY x",
>      {})
> -
>  test:finish_test(
1. Stray diff in boundary1.test.lua.

>>> diff --git a/test/sql-tap/boundary2.test.lua b/test/sql-tap/boundary2.test.lua
>>> index 3eaef75dc..be4b8750d 100755
>>> --- a/test/sql-tap/boundary2.test.lua
>>> +++ b/test/sql-tap/boundary2.test.lua
>>> @@ -1,6 +1,6 @@
>>>   #!/usr/bin/env tarantool
>>>   test = require("sqltester")
>>> -test:plan(3021)
>>> +test:plan(2965)
>>>     --!./tcltestrunner.lua
>>>   -- 2008 December 11
>>> @@ -7462,6 +7462,7 @@ test:do_execsql_test(
>>>       "SELECT a FROM t1 WHERE r > 9.22337303685477580800e+18 ORDER BY a DESC",
>>>       {})
>>>   +if false then
>>
>> 6. I thought you have removed all these 'if false'. Please, do it.
> 
> I did it in boundary3 test and forgot about this one. Fixed:

2. Sorry, still can be found in cast.test.lua.

Also stray empty lines on 526, 763.

3. if false in in3.test.lua.