From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AEFB3469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 18:29:26 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <20200608104450.157253-1-gorcunov@gmail.com>
 <20200608104450.157253-2-gorcunov@gmail.com>
Message-ID: <e731a0e8-1268-c1d4-6093-c32169e7ca5e@tarantool.org>
Date: Mon, 8 Jun 2020 18:29:25 +0300
MIME-Version: 1.0
In-Reply-To: <20200608104450.157253-2-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for your patch. See 1 comment below.

On 08/06/2020 13:44, Cyrill Gorcunov wrote:
> The dynamic configuration of logging level and
> format now goes via log module. These functions
> are no longed needed.
> 
> Part-of #689
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/box/lua/cfg.cc | 24 ------------------------
>   1 file changed, 24 deletions(-)
> 
> diff --git a/src/box/lua/cfg.cc b/src/box/lua/cfg.cc
> index ed56b0b5c..a5b15e527 100644
> --- a/src/box/lua/cfg.cc
> +++ b/src/box/lua/cfg.cc
> @@ -87,28 +87,6 @@ lbox_cfg_set_replication(struct lua_State *L)
>   	return 0;
>   }
>   
> -static int
> -lbox_cfg_set_log_level(struct lua_State *L)
> -{
> -	try {
> -		box_set_log_level();
> -	} catch (Exception *) {
> -		luaT_error(L);
> -	}
> -	return 0;
> -}
> -
> -static int
> -lbox_cfg_set_log_format(struct lua_State *L)
> -{
> -	try {
> -		box_set_log_format();
> -	} catch (Exception *) {
> -		luaT_error(L);
> -	}
> -	return 0;
> -}
> -

I assume that "box_set_log_level" and "box_set_log_format" should be 
removed as well.