From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 33BBF452566 for ; Sat, 16 Nov 2019 00:25:02 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: Date: Fri, 15 Nov 2019 22:31:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] test: ensure instances are stopped in tctl test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the patch! LGTM. On 15/11/2019 02:19, Alexander Turenko wrote: > The problem appears after 6c627af390c3fd521ffef77c443aeb3f5cb0b713 > ('test: tarantoolctl: verify delayed box.cfg()'), where the test case > was changed and it doesn't more assume an error at the instance start. > So we need to stop it to prevent a situation when instances are stays > after `make test`. > > Fixes #4600. > --- > > https://github.com/tarantool/tarantool/issues/4600 > https://github.com/tarantool/tarantool/tree/Totktonada/gh-4600-fix-tarantoolctl-test > > BTW, thanks for the report! That was my mistake. > > test/app-tap/tarantoolctl.test.lua | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >