From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8FD242EF1D
	for <tarantool-patches@freelists.org>; Mon,  3 Dec 2018 11:19:47 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Gqx_EdgEJ1CF for <tarantool-patches@freelists.org>;
	Mon,  3 Dec 2018 11:19:47 -0500 (EST)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 22C2D2EF1A
	for <tarantool-patches@freelists.org>; Mon,  3 Dec 2018 11:19:46 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH] sql: increment VIEW counter for
 tables within sub-select
References: <20181203150037.60513-1-korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <e6ab34cd-9be7-294f-f83d-70038d7e457f@tarantool.org>
Date: Mon, 3 Dec 2018 19:19:40 +0300
MIME-Version: 1.0
In-Reply-To: <20181203150037.60513-1-korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

Hi! Thanks for the patch!

The patch is ok, but please, apply this
diff:

diff --git a/src/box/alter.cc b/src/box/alter.cc
index eca217511..03ba68adc 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -1515,8 +1515,8 @@ update_view_references(struct Select *select, int update_value,
  		uint32_t space_id;
  		if (schema_find_id(BOX_SPACE_ID, 2, space_name,
  				   strlen(space_name), &space_id) != 0) {
-				sqlite3SrcListDelete(sql_get(), list);
-				return -1;
+			sqlite3SrcListDelete(sql_get(), list);
+			return -1;
  		}
  		if (space_id == BOX_ID_NIL) {
  			if (! suppress_error) {


After it the patch LGTM.