From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E8EF4469719 for ; Tue, 22 Sep 2020 20:53:59 +0300 (MSK) References: <1599560532-27089-1-git-send-email-alyapunov@tarantool.org> <1599560532-27089-11-git-send-email-alyapunov@tarantool.org> <20200915175921.GC23208@tarantool.org> From: Aleksandr Lyapunov Message-ID: Date: Tue, 22 Sep 2020 20:53:58 +0300 MIME-Version: 1.0 In-Reply-To: <20200915175921.GC23208@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH v4 10/12] txm: use new tx manager in memtx List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org Hi, thanks for the review. Almost all if fixed, see my comment below: On 15.09.2020 20:59, Nikita Pettik wrote: > >> diff --git a/src/box/vinyl.c b/src/box/vinyl.c >> index aa6e50f..cee39c5 100644 >> --- a/src/box/vinyl.c >> +++ b/src/box/vinyl.c >> @@ -1076,7 +1076,7 @@ vinyl_space_check_format(struct space *space, struct tuple_format *format) >> return -1; >> >> /* See the comment in vinyl_space_build_index(). */ >> - txn_can_yield(txn, true); >> + bool could_yield = txn_can_yield(txn, true); > Don't get why vinyl related functions should be involved in this change.. > The rest is OK. These vinyl functions are called in memtx transaction that performs alter of a vinyl space.. In the code vinyl changes behavior of the memtx transaction.