From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 560A721B89 for ; Sat, 28 Apr 2018 05:29:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gQ_lWO1d00j0 for ; Sat, 28 Apr 2018 05:29:30 -0400 (EDT) Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9C64821B83 for ; Sat, 28 Apr 2018 05:29:29 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 0/2] Fix lost format on update operation References: From: Vladislav Shpilevoy Message-ID: Date: Sat, 28 Apr 2018 12:29:24 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Konstantin Osipov Cc: Kirill Shcherbatov Now the patchset LGTM. Kostja, please, look at this. On 06/04/2018 19:24, Kirill Shcherbatov wrote: > Branch: http://github.com/tarantool/tarantool/tree/gh-3051-lost-format-while-tuple-update > Issue: https://github.com/tarantool/tarantool/issues/3051 > > Kirill Shcherbatov (2): > Fixed invalid check in lbox_tuple_transform. > Fixed lost format on update and upsert operations. > > src/box/lua/tuple.c | 6 ++-- > src/box/memtx_tuple.cc | 1 + > src/box/tuple.c | 42 ++++++++++++++++-------- > src/box/tuple.h | 6 +++- > src/box/tuple_format.h | 5 ++- > src/box/vy_stmt.c | 7 ++++ > src/box/vy_stmt.h | 9 +++++ > test/box/update.result | 85 ++++++++++++++++++++++++++++++++++++++++++++++++ > test/box/update.test.lua | 28 ++++++++++++++++ > 9 files changed, 171 insertions(+), 18 deletions(-) >