From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4D82D70652; Fri, 12 Nov 2021 02:59:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D82D70652 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1636675181; bh=PUNKU6iAdoFpsYabB3Byb//Dwxx9OWDd/K7Qtmfvovw=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=WNezrC2A/jTsgmzLYPbaLRrZBwXlo4fJTGrKl4C8SjwYKgXGcQ+GIRDQMRlQGy4rV cbvJMLu0EYt7AKeIN6nRWAMUTS9wI3NBZRrjHGVEYn8hV4Q2N42hkTs3xi+eCXu5Af 2Unpa/JkawFaemHEf6+/cvyTMmxRFdFVcXnAUyA4= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1551070657 for ; Fri, 12 Nov 2021 02:54:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1551070657 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mlJu0-0003tY-DH; Fri, 12 Nov 2021 02:54:44 +0300 To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org Date: Fri, 12 Nov 2021 00:54:29 +0100 Message-Id: X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9731B3922EC0639792FFC8A1478656943FA9F74D7A497B1C400894C459B0CD1B9F1FACBD9BD64154C12838263427C207E7F76FE7EF67E38FF906DE0852CB233E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE737BB76880A4CA9A4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637976142D429C486548638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D841BAC7BFAA20691E6FF12C6314B49C16117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC9FC99A4BA45EE8B4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86D28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C7E9FEBB9C11794A1F1E4BBD558E5208A0CF86927F5BB14469C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EF11E5B64A728E1589699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34197948450CB5442A642414B917A77DADC7F4BD687D7899134DCBB6C9375A19DDA12D83106C3543891D7E09C32AA3244C948F967A41240C401606663CC47A49FC3A92A9747B6CC886729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj4t8MBgWr8bLrXZAQLHqR1Q== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DA3ECFFD595FDEC67B583812BB5F112B43841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 08/11] luatest: copy config in cluster:build_server() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" It takes box.cfg config as an argument. And changes the argument by adding a new key 'command'. If the caller wants to pass the same box.cfg or slightly modified to several build_server() calls, it won't work - all options will be the same on all instances. For example: local cfg = {...} cfg.replication = {url1} cluster:build_server(cfg) cfg.replication = {url2} cluster:build_server(cfg) It will not work. Both servers will get the same 'command' and the same 'replication'. --- test/luatest_helpers/cluster.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/test/luatest_helpers/cluster.lua b/test/luatest_helpers/cluster.lua index 01291b43c..43e3479f7 100644 --- a/test/luatest_helpers/cluster.lua +++ b/test/luatest_helpers/cluster.lua @@ -93,6 +93,7 @@ end function Cluster:build_server(server_config, instance_file) instance_file = instance_file or 'default.lua' + server_config = table.deepcopy(server_config) server_config.command = fio.pathjoin(root, 'test/instances/', instance_file) assert(server_config.alias, 'Either replicaset.alias or server.alias must be given') local server = Server:new(server_config) -- 2.24.3 (Apple Git-128)