From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0F1E522F10 for ; Sat, 7 Sep 2019 09:48:00 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GHeZUbSO4J3r for ; Sat, 7 Sep 2019 09:47:59 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C2C9E20EB3 for ; Sat, 7 Sep 2019 09:47:59 -0400 (EDT) From: Vladislav Shpilevoy Subject: [tarantool-patches] [PATCH 1/1] wal: deprecate wal_max_rows in favour of wal_max_size Date: Sat, 7 Sep 2019 15:51:34 +0200 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org wal_max_rows does not allow to properly limit size of WAL logs. A user would need to estimate size of each WAL row to do that. Now WAL supports option wal_max_size allowing to limit WAL size much more precise. Part of #3762 --- Note: Based on branch 1.10. It should be pushed to 1.10 and cherry-picked to all > 1.10 and < master. Issue: https://github.com/tarantool/tarantool/issues/3762 Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid src/box/lua/load_cfg.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua index 77f57eb05..432a3374b 100644 --- a/src/box/lua/load_cfg.lua +++ b/src/box/lua/load_cfg.lua @@ -291,6 +291,7 @@ local translate_cfg = { panic_on_snap_error = {'force_recovery', function (p) return not p end}, panic_on_wal_error = {'force_recovery', function (p) return not p end}, replication_source = {'replication'}, + wal_max_rows = {'wal_max_size'}, } -- Upgrade old config -- 2.20.1 (Apple Git-117)