From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 11DC346970E for ; Thu, 6 Feb 2020 01:11:08 +0300 (MSK) References: <20200205110944.GA9833@atlas> From: Vladislav Shpilevoy Message-ID: Date: Wed, 5 Feb 2020 23:11:05 +0100 MIME-Version: 1.0 In-Reply-To: <20200205110944.GA9833@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tarantool-patches@dev.tarantool.org, imun@tarantool.org, korablev@tarantool.org Hi! On 05/02/2020 12:09, Konstantin Osipov wrote: > * Vladislav Shpilevoy [20/02/05 01:53]: >> The patchset fixes float value truncation in >> tuple/space:update/upsert. First commit fixes the actual issue, >> but introduces another bug that a float value can be stored into a >> field having double type in its format. > > Thanks for CCing. While I find the general idea of the series quite > nice, I don't know why it's a priority. It was assigned to a milestone, and the code still is in my head's "cache" after JSON updates, so I decided to fix it. > Did anyone actually complain? Nobody so far. Just me. > PS Would be best if you don't Cc/To me with the entire series next > time, but @mention me on the list if you would like to get my review. I am > reading all patches on the list anyway, no need to copy them to my inbox. Ok, will do that next time.