From: Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] lua/log: remove 'module' option type
Date: Tue, 13 Apr 2021 18:42:55 +0300 [thread overview]
Message-ID: <e484e201-ee37-715d-3000-fe942ce7f9ad@tarantool.org> (raw)
In-Reply-To: <YHWyvDcwmL1iIXJf@grain>
On 4/13/21 6:03 PM, Cyrill Gorcunov wrote:
> On Tue, Apr 13, 2021 at 05:52:11PM +0300, Leonid Vasiliev wrote:
>> Hi! Thank you for the patch.
>> LGTM.
>> Cyrill Gorcunov. please also see the patch.
>>
>
> Guys, I don't like that we're dropping the "module" here. But
> please gimme today's evening I'll try to come up with some
> idea and code to share, ok? I'll write another email once
> I get ready.
>
Bro, of course we will wait for your feedback)
next prev parent reply other threads:[~2021-04-13 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 12:45 [Tarantool-patches] [PATCH v2 0/2] Set cfg via environment variables Roman Khabibov via Tarantool-patches
2021-04-13 12:45 ` [Tarantool-patches] [PATCH v2 1/2] lua/log: remove 'module' option type Roman Khabibov via Tarantool-patches
2021-04-13 14:52 ` Leonid Vasiliev via Tarantool-patches
2021-04-13 15:03 ` Cyrill Gorcunov via Tarantool-patches
2021-04-13 15:42 ` Leonid Vasiliev via Tarantool-patches [this message]
2021-04-13 12:45 ` [Tarantool-patches] [PATCH v2 2/2] box: set cfg via environment variables Roman Khabibov via Tarantool-patches
2021-04-13 15:39 ` Leonid Vasiliev via Tarantool-patches
2021-04-13 17:57 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e484e201-ee37-715d-3000-fe942ce7f9ad@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=lvasiliev@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] lua/log: remove '\''module'\'' option type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox